Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #374

Merged
merged 70 commits into from
May 11, 2020
Merged

Merge upstream #374

merged 70 commits into from
May 11, 2020

Conversation

richard-cox
Copy link
Member

No description provided.

@richard-cox richard-cox added the in progress In Progress label May 5, 2020
@richard-cox richard-cox marked this pull request as draft May 5, 2020 13:20
@codecov-io
Copy link

Codecov Report

Merging #374 into master will increase coverage by 0.80%.
The diff coverage is 53.60%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   58.51%   59.32%   +0.80%     
==========================================
  Files        1039     1047       +8     
  Lines       33108    33423     +315     
  Branches     4559     4588      +29     
==========================================
+ Hits        19372    19827     +455     
+ Misses      13736    13596     -140     

@richard-cox richard-cox added ready for review Ready for review and removed in progress In Progress labels May 7, 2020
@richard-cox richard-cox marked this pull request as ready for review May 7, 2020 13:47
richard-cox and others added 21 commits May 7, 2020 14:58
* Speed up form fill

* Manage users fix?

* Wait slightly longer

* Improve error output in tests

* Fix invite users error msg check

* Fix manage users e2e

* Need checked in form to check box correctly
* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

* Fix root list colour in metrics summary page dark mode

* Fix first row alignment in users table

* Fix invite user e2e test (see cloudfoundry#4272)

* Disable random route override setting when deploying apps in e2e tests
- pushes route over max 63 chars

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
…4258)

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

Co-authored-by: Richard Cox <richard.cox@suse.com>
* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
* E2E Cleanup script: clean other users and reduce time to 1 hour

* Remove superfluous blank lines

* Revert back to 2 hours
* Speed up form fill

* Fix page set setting

* Remove whitespace
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 4e6a37b into master May 11, 2020
@nwmac nwmac deleted the merge-upstream branch May 11, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants