Add ability to import K8S endpoints from kube config file #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tidied up selection component - move non-ui logic into helper - move record of clusters into helper - tidied up config helper - fixed select all intermediate state on bizare selections & first load - cleans a lot of table datasource interfaces
- Fix table header alignment - Fix checkbox table column alignment
…r to review final step
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 59.61% 59.26% -0.35%
==========================================
Files 1057 1068 +11
Lines 33286 33781 +495
Branches 4673 4754 +81
==========================================
+ Hits 19844 20021 +177
- Misses 13442 13760 +318 |
- tidy up - remove /kubeconfig.yaml fetch - fix select all at indeterminate state (should always select all) - fix apply for auto skip ssl
…tepper, minor changes
- remove border radius after expansion change - error rows have large indent to help show associated row - remove old styles that weren't applied following expansion change
richard-cox
added
ready for review
richard-cox
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.