Workload Summary Pod/Container Ring Chart Fixes #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Jun 12, 2020
•
richard-cox
commented
- fix expanded pod status when there are terminated containers
- in container ready/not ready count ignore containers that were terminated successfully
- sort pod status labels in pod status ring chart to reduce values switching
- fix ring chart pie/legend colour mismatch
- fixes Workload Summary: Ring chart series toggled on refresh & legend vs ring colours missmatched #389
- fixes Workload Summary: Improve Ready/Not Ready stats when there are terminated containers #388
…nto merge-upstream-entity-access
…nto merge-upstream-entity-access
…eam-entity-access
…eam-entity-access
…eam-entity-access
- fix expanded pod status when there are terminated containers - in container ready/not ready count ignore containers that were terminated succesfully - sort pod status labels in pod status ring chart to reduce values switching
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 59.41% 59.35% -0.06%
==========================================
Files 1052 1052
Lines 33100 33119 +19
Branches 4636 4643 +7
==========================================
- Hits 19665 19659 -6
- Misses 13435 13460 +25 |
- ensure legend colours update on changes of data - apply a better custom colour to 'completed' state (rusty red --> sky blue)
richard-cox
added
ready for review
richard-cox
commented
Jun 16, 2020
custom-src/frontend/app/custom/kubernetes/workloads/release/tabs/helm-release-helper.service.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/components/ring-chart/ring-chart.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.