Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do expensive helm repo update when starting terminal #453

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Aug 21, 2020

fixes #452

@nwmac nwmac added this to the 4.1.0 milestone Aug 21, 2020
@nwmac nwmac self-assigned this Aug 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   56.28%   56.28%           
=======================================
  Files         898      898           
  Lines       29318    29318           
  Branches     4234     4234           
=======================================
  Hits        16501    16501           
  Misses      12817    12817           

@nwmac nwmac added the ready for review Ready for review label Aug 25, 2020
@richard-cox richard-cox merged commit 4843986 into master Aug 27, 2020
@richard-cox richard-cox deleted the kube-terminal-helm branch August 27, 2020 14:37
@richard-cox richard-cox removed this from the 4.1.0 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Terminal: It can take a long time to get to the prompt with large helm repositories registered
3 participants