Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Ingress resource template #152

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Improved Ingress resource template #152

merged 3 commits into from
Apr 15, 2019

Conversation

f0rmiga
Copy link
Contributor

@f0rmiga f0rmiga commented Apr 10, 2019 •
edited
Loading

Description

  • Aligned better with the practices seen on stable/charts.
  • Allowed passing ingress.tls.crt and ingress.tls.key.
  • Allowed passing ingress.annotations, and handling default annotations.
  • Hardcoded UAA port as it is not modifiable.
  • Updated make scripts to reflect the changes.

Ties to:

Test plan

Part of SUSE/scf#2305.

@f0rmiga f0rmiga added the wip label Apr 10, 2019
@f0rmiga f0rmiga mentioned this pull request Apr 10, 2019
Merged
@f0rmiga f0rmiga removed the wip label Apr 10, 2019
mook-as
mook-as requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly backwards-compatibility concerns.

chart-parts/ingress.yaml Show resolved Hide resolved
chart-parts/ingress.yaml Show resolved Hide resolved
chart-parts/ingress.yaml Show resolved Hide resolved
chart-parts/ingress.yaml Show resolved Hide resolved
mook-as
mook-as reviewed Apr 11, 2019
View reviewed changes
Copy link
Member

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0rmiga mentions that ingress was a preview in the previous release, and therefore we can (for now!) ignore backwards compatibility issues.

chart-parts/ingress.yaml Show resolved Hide resolved
@f0rmiga f0rmiga requested a review from mook-as April 12, 2019 00:16
mook-as
mook-as requested changes Apr 12, 2019
View reviewed changes
chart-parts/ingress.yaml Show resolved Hide resolved
chart-parts/ingress.yaml Show resolved Hide resolved
@f0rmiga f0rmiga requested a review from mook-as April 12, 2019 00:59
mook-as
mook-as approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay; now testing to make sure this works 😀

@mook-as mook-as merged commit 3ef3609 into develop Apr 15, 2019
@mook-as mook-as deleted the f0rmiga/improved-ingress branch April 15, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mook-as mook-as mook-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f0rmiga @mook-as