This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Ingress default values #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey f0rmiga! The commit authors and yourself have already signed the CLA. |
f0rmiga
force-pushed
the
f0rmiga/ingress-default-values
branch
from
831500d
to
4632c21
Compare
This was referenced Apr 10, 2019
mook-as
approved these changes
Apr 11, 2019
mook-as
suggested changes
Apr 12, 2019
There was a problem hiding this comment.
Line 219 in e67442a
services.ingress (or possibly move the whole new part in there).
mook-as
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Fissile should generate the
values.yamlwith the specified ingress default values (as seen on the unit test).