This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix the docker ps command #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
suggested changes
Jun 6, 2018
helpers.go
Outdated
|
|
||
| return "", fmt.Errorf("Cannot find image %s", name) | ||
| return imageID, err |
There was a problem hiding this comment.
Although err == nil, please use nil in the return statement instead. It's easier to understand and a common pattern.
Previously the docker psCmd function made use of getImageID which expects a repo:tag combination, but was called with the ID which the function was expected to return. Thus the call of getImageID was redundant in this place. The tests were updated to reflect the new behaviour. Another problem that influenced zypper-docker ps was that an image was not added to the outdated string in the cache file after a zypper-docker up or patch if the image to be updated was parsed with it's image ID. Fixes: SUSE#144 Fixes: SUSE#145 Signed-off-by: Pascal Arlt <parlt@suse.com>
vrothberg
approved these changes
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the docker psCmd function made use of getImageID
which expects a repo:tag combination, but was called with the
ID which the function was expected to return. Thus the call
of getImageID was redundant in this place.
The tests were updated to reflect the new behaviour.
Another problem that influenced zypper-docker ps was that
an image was not added to the outdated string in the cache
file after a zypper-docker up or patch if the image to be
updated was parsed with it's image ID.
Fixes: #144
Fixes: #145
Signed-off-by: Pascal Arlt parlt@suse.com