Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking for full ES6 Module migration and possibly further modularization #242

Closed
1 of 8 tasks
brettz9 opened this issue May 24, 2018 · 1 comment
Closed
1 of 8 tasks

Comments

@brettz9
Copy link
Contributor

brettz9 commented May 24, 2018

A major ES6 Module refactoring for our source is on the way, (complete) but a few dependencies are not yet available as ES6 modules (at least without Rollup)

  1. jQuery and jQueryUI
  2. jsPDF (at least our version of it); see jquery.contextMenu.js is version 1.01 - 4 years old (js-hotkeys, jspdf, canvg/rgbcolor/stackblur-canvas, mathjax also have new versions and/or need updating from ours) #51
  3. MathJax (and its dependency TeX-AMS-MML_SVG.js) (Will just need to use mathjax-v3)
  4. qunit (For testing)
  5. sinon (Just needs npm bump now) and sinon-test (For testing)
  6. Once import() is widely available, we could avoid loading them via script tag and allow them to simply export an object without needing to import svg-editor.js and call addExtensions. Currently added an importModule polyfill (and importScript fallback).
  7. Consider, in place of the embedded API, exporting a module which added all dependencies, including jQuery and the default HTML. Have to weigh this with the cost of adding all the default HTML dynamically and whether the styling could support placement elsewhere in the flow of the document. One option might be a syntax which supported Server-side Rendering (so as to minimize initial DOM processing) or to allow pre-compilation to static HTML.
  8. See about spinning off some of the components of the project into their own ES6 Module-friendly npm module
@jfhenon
Copy link
Collaborator

jfhenon commented May 23, 2021

This issue is not relevant anymore with V7.

@jfhenon jfhenon closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants