Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Tag V1.1 for use w/ Cocoapods (if ready) #119

Closed
augustj opened this issue Oct 31, 2013 · 3 comments
Closed

Please Tag V1.1 for use w/ Cocoapods (if ready) #119

augustj opened this issue Oct 31, 2013 · 3 comments

Comments

@augustj
Copy link

augustj commented Oct 31, 2013

I'd like to create a v1.1 cocoapod spec that includes the fixes for iOS7. Cocoapods require tags, rather than just a branch/ref.
If 1.1 is ready, could you please tag it?
Thanks.

@adamgit
Copy link
Contributor

adamgit commented Nov 18, 2013

Done!

https://github.com/SVGKit/SVGKit/releases/tag/v1.1.0

(re-open if that doesn't work - I checked it, and it seems to have gone to the main repo OK)

@adamgit adamgit closed this as completed Nov 18, 2013
@foulkesjohn
Copy link

Is there a podspec for 1.1.0? I've tried to make my own but I'm hitting issues

@augustj
Copy link
Author

augustj commented Dec 6, 2013

@foulkesjohn
I ended up copying the existing to make my own version that excluded the CocoaLumberjack files and defined ddLogLevel as extern.
Here is my repo of podspecs: https://github.com/augustj/Cocoapods_Specs
There have been recent changed in CocoaLumberjack regarding definition of ddLogLevel. Here's the thread for that: CocoaLumberjack/CocoaLumberjack#162

I have not updated my spec to reflect the recent 1.1.0 tagging yet - mine still pulls from master (but that should be easy for you to change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants