ENHANCED: Use OpenSSL default curves (ecdh_curve/1) in OpenSSL >= 1.1.0. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier OpenSSL versions do not set a curve by default. We use prime256v1 in such cases, as before, but no longer override the new library defaults with this curve. This commit makes stronger curves automatically available when using newer OpenSSL versions, unless users have explicitly asked for a specific curve. A major attraction of OpenSSL 1.1.0 is X25519, which is the new default curve in that version for ECDH. To disable ECDH entirely, use the cipher_list/1 option (also as before). In the future, ecdh_curve/1 will be superseded by a new option that binds SSL_CTX_set1_groups. However, this currently affects both ECDH and ECDSA, and we will adopt the eventual solution of OpenSSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier OpenSSL versions do not set a curve by default. We use
prime256v1 in such cases, as before, but no longer override the new
library defaults with this curve.
This commit makes stronger curves automatically available when using
newer OpenSSL versions, unless users have explicitly asked for a
specific curve. A major attraction of OpenSSL 1.1.0 is X25519, which
is the new default curve in that version for ECDH.
To disable ECDH entirely, use the cipher_list/1 option (also as before).
In the future, ecdh_curve/1 will be superseded by a new option that
binds SSL_CTX_set1_groups. However, this currently affects both ECDH
and ECDSA, and we will adopt the eventual solution of OpenSSL.
See openssl/openssl#2033 for more information.