Calculate stellar birth pressure #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robjmcgibbon
commented
Jan 17, 2024
robjmcgibbon
commented
- Add StellarBirthPressure properties
- Replace LogAverage calculations with median for StellarBirthDensity and StellarBirthTemperature
- Add StellarBirthPressure - Replace LogAverage with Median
Conflicts: property_table.py subhalo_properties.py
EvgeniiChaikin
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Almost all looks good!
One remaining step is to update aperture properties, which also contain LogarithmicallyAveragedStellarBirthDensity
This version of SOAP will not be happy to run because LogarithmicallyAveragedStellarBirthDensity exists in aperture properties but has been removed from property_table.py
Probably the easiest fix would be to just remove
"LogarithmicallyAveragedStellarBirthDensity",
"MaximumStellarBirthDensity",
"MinimumStellarBirthDensity"
from aperture properties because we currently only use those fields as part of subhalo properties.
This was referenced Jan 19, 2024
|
Good catch, yep I've just updated aperture_properties |
EvgeniiChaikin
approved these changes
Jan 19, 2024
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.