Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Make container's journal entry comments predictable #93

Merged
merged 2 commits into from
May 8, 2024

Conversation

linkdd
Copy link
Collaborator

@linkdd linkdd commented May 7, 2024

Decision Record

In order to better filter journal entries on a container, we want to make the format of the comments more predictable:

Kind Comment pattern
info operation $op: pending
success operation $op: ok
warning operation $op: failed
danger operation $op: error => $err

For example:

  • operation start: ok
  • operation create: error => {some big json}

Changes

  • 🔊 Update container's journal entry comments
  • 🔖 v0.22.0

@linkdd linkdd requested review from lvenier and dzove855 May 7, 2024 18:20
@linkdd linkdd self-assigned this May 7, 2024
Copy link
Contributor

@lvenier lvenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working but I am puzzled by the none event (there is only pending event) :

image

I would do something like that to have the succeed of none operation :

image

or no pending for none and directly a success message

@linkdd linkdd merged commit 80f5067 into main May 8, 2024
1 check passed
@linkdd linkdd deleted the container-journal-entries branch May 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants