show info, sharedfeature, dataarea #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show info and sharedfeature element show additional dataareas in rom element
|
this patch need #52, combine pulls is currently not a feature of github? |
mnadareski
requested changes
Feb 22, 2022
| @@ -332,8 +337,10 @@ private bool ReadPart(XmlReader reader, Machine machine, Part part, bool statsOn | |||
| List<DatItem> roms = ReadDataArea(reader.ReadSubtree(), dataArea); | |||
|
|
|||
| // If we got valid roms, add them to the list | |||
| if (roms != null) | |||
| items.AddRange(roms); | |||
| if (!String.IsNullOrEmpty(string.Join(", ", roms))) | |||
There was a problem hiding this comment.
I'd prefer consistency here in using String and string with a preference being on string.
| @@ -577,6 +584,7 @@ protected override ItemType[] GetSupportedTypes() | |||
| ItemType.DipSwitch, | |||
| ItemType.Disk, | |||
| ItemType.Info, | |||
| ItemType.DataArea, | |||
There was a problem hiding this comment.
This may or may not be doing what you think it's doing. Did you look at how the Rom items are being written out?
| @@ -332,8 +337,10 @@ private bool ReadPart(XmlReader reader, Machine machine, Part part, bool statsOn | |||
| List<DatItem> roms = ReadDataArea(reader.ReadSubtree(), dataArea); | |||
|
|
|||
| // If we got valid roms, add them to the list | |||
| if (roms != null) | |||
| items.AddRange(roms); | |||
| if (!String.IsNullOrEmpty(string.Join(", ", roms))) | |||
There was a problem hiding this comment.
I don't fully understand what this is supposed to be doing. Why are you joining a list of DatItems as if they're strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show info and sharedfeature element
show additional dataareas in rom element