Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dataareas to part #52

Merged
merged 2 commits into from
Feb 22, 2022
Merged

add dataareas to part #52

merged 2 commits into from
Feb 22, 2022

Conversation

Lothrien
Copy link
Contributor

to add additional dataareas in rom element

@Lothrien
add dataareas to part
0d582a6 
to add additional dataareas in rom element
@Lothrien Lothrien mentioned this pull request Nov 28, 2021
Open
@Lothrien
adding dataareas
1d2beb3 
while updating vs code, references where lost, but i hope i'll get everything to the correct place...
@Lothrien Lothrien mentioned this pull request Nov 28, 2021
Open
mnadareski
mnadareski approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@mnadareski mnadareski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is essentially a no-op by itself to then support other things later. By itself, this is fine.

@mnadareski mnadareski merged commit 470fc92 into SabreTools:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnadareski mnadareski mnadareski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lothrien @mnadareski