Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Input Layer for nn Interface #621

Closed
Gerhardsa0 opened this issue Apr 12, 2024 · 1 comment · Fixed by #625
Closed

feat: add Input Layer for nn Interface #621

Gerhardsa0 opened this issue Apr 12, 2024 · 1 comment · Fixed by #625
Assignees
@Gerhardsa0
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Apr 12, 2024 •
edited

Is your feature request related to a problem?

We are right now working on translating the safe-ds data into pytorch tensors. The translation is defined in the dataclasses them self, but the definiton how, should be defined on the input layer interface.

Desired solution

Create Input Layer Interface, with Type parameter, so we have static type analysis.
@Gerhardsa0 Gerhardsa0 added the enhancement 💡 New feature or request label Apr 12, 2024
@Gerhardsa0 Gerhardsa0 self-assigned this Apr 17, 2024
@Gerhardsa0 Gerhardsa0 linked a pull request Apr 17, 2024 that will close this issue
feat: Add InputConversion & OutputConversion for nn interface #625
Merged
@Gerhardsa0 Gerhardsa0 mentioned this issue Apr 17, 2024
Merged
Gerhardsa0 added a commit that referenced this issue Apr 18, 2024
@Gerhardsa0 @Marsmaennchen221
@megalinter-bot @WinPlay02 @sibre28
feat: Add InputConversion & OutputConversion for nn interface (#625)
fd723f7 
Closes #621 

### Summary of Changes

added input and output conversion Interface
also added this functionality for Table

---------

Co-authored-by: Alexander Gréus <alexgreus51@gmail.com>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
Co-authored-by: WinPlay02 <winplay02_gh@woberlaender.de>
Co-authored-by: Simon <s6snbreu@uni-bonn.de>
Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue May 1, 2024
@semantic-release-bot
chore(release): 0.22.0 [skip ci]
43717e0 
## [0.22.0](v0.21.0...v0.22.0) (2024-05-01)

### Features

* `is_fitted` is now always a property ([#662](#662)) ([b1db881](b1db881)), closes [#586](#586)
* add `Column.missing_value_count` ([#682](#682)) ([f084916](f084916)), closes [#642](#642)
* Add `InputConversion` & `OutputConversion` for nn interface ([#625](#625)) ([fd723f7](fd723f7)), closes [#621](#621)
* Add hash,eq and sizeof in ForwardLayer ([#634](#634)) ([72f7fde](72f7fde)), closes [#633](#633)
* allow using tables that already contain target for prediction ([#687](#687)) ([e9f1cfb](e9f1cfb)), closes [#636](#636)
* callback `Row.sort_columns` takes four parameters instead of two tuples ([#683](#683)) ([9c3e3de](9c3e3de)), closes [#584](#584)
* rename `group_rows_by` in `Table` to `group_rows` ([#661](#661)) ([c1644b7](c1644b7)), closes [#611](#611)
* rename `number_of_column` in `Row` to `number_of_columns` ([#660](#660)) ([0a08296](0a08296)), closes [#646](#646)
* rework `TaggedTable` ([#680](#680)) ([db2b613](db2b613)), closes [#647](#647)
* show missing value count/ratio in summarized statistics ([#684](#684)) ([74b8a35](74b8a35)), closes [#619](#619)
* specify `extras` instead of `features` in `to_tabular_dataset` ([#685](#685)) ([841657f](841657f)), closes [#623](#623)

### Bug Fixes

* actually use `kernel` of support vector machines for training ([#681](#681)) ([09c5082](09c5082)), closes [#602](#602)

### Performance Improvements

* Faster plot_histograms and more reliable plots ([#659](#659)) ([b5f0a12](b5f0a12))
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerhardsa0 Gerhardsa0

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add InputConversion & OutputConversion for nn interface Safe-DS/Library
2 participants
@lars-reimann @Gerhardsa0