Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hash,eq and sizeof in ForwardLayer #634

Merged
merged 12 commits into from
Apr 22, 2024

Conversation

sibre28
Copy link
Contributor

@sibre28 sibre28 commented Apr 19, 2024

Closes #633

Summary of Changes

Added __hash__, __eq__ and __sizeof__ in ForwardLayer

@sibre28 sibre28 requested a review from a team as a code owner April 19, 2024 13:42
@sibre28 sibre28 linked an issue Apr 19, 2024 that may be closed by this pull request
@sibre28 sibre28 changed the title Add hash,eq and sizeof in ForwardLayer feat: Add hash,eq and sizeof in ForwardLayer Apr 19, 2024
Copy link
Contributor

github-actions bot commented Apr 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.79s
✅ PYTHON mypy 2 0 2.17s
✅ PYTHON ruff 2 0 0 0.23s
✅ REPOSITORY git_diff yes no 0.21s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d58c32f) to head (cfadc7c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #634   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         4812      4825   +13     
=========================================
+ Hits          4812      4825   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this docstring needs to include the return name

src/safeds/ml/nn/_forward_layer.py Outdated Show resolved Hide resolved
Co-authored-by: WinPlay02 <winplay02_gh@woberlaender.de>
@sibre28 sibre28 merged commit 72f7fde into main Apr 22, 2024
8 checks passed
@sibre28 sibre28 deleted the 633-add-hasheq-and-sizeof-in-forwardlayer branch April 22, 2024 14:46
lars-reimann pushed a commit that referenced this pull request May 1, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-05-01)

### Features

* `is_fitted` is now always a property ([#662](#662)) ([b1db881](b1db881)), closes [#586](#586)
* add `Column.missing_value_count` ([#682](#682)) ([f084916](f084916)), closes [#642](#642)
* Add `InputConversion` & `OutputConversion` for nn interface ([#625](#625)) ([fd723f7](fd723f7)), closes [#621](#621)
* Add hash,eq and sizeof in ForwardLayer ([#634](#634)) ([72f7fde](72f7fde)), closes [#633](#633)
* allow using tables that already contain target for prediction ([#687](#687)) ([e9f1cfb](e9f1cfb)), closes [#636](#636)
* callback `Row.sort_columns` takes four parameters instead of two tuples ([#683](#683)) ([9c3e3de](9c3e3de)), closes [#584](#584)
* rename `group_rows_by` in `Table` to `group_rows` ([#661](#661)) ([c1644b7](c1644b7)), closes [#611](#611)
* rename `number_of_column` in `Row` to `number_of_columns` ([#660](#660)) ([0a08296](0a08296)), closes [#646](#646)
* rework `TaggedTable` ([#680](#680)) ([db2b613](db2b613)), closes [#647](#647)
* show missing value count/ratio in summarized statistics ([#684](#684)) ([74b8a35](74b8a35)), closes [#619](#619)
* specify `extras` instead of `features` in `to_tabular_dataset` ([#685](#685)) ([841657f](841657f)), closes [#623](#623)

### Bug Fixes

* actually use `kernel` of support vector machines for training ([#681](#681)) ([09c5082](09c5082)), closes [#602](#602)

### Performance Improvements

* Faster plot_histograms and more reliable plots ([#659](#659)) ([b5f0a12](b5f0a12))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hash,eq and sizeof in ForwardLayer
4 participants