Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics as methods of models #64

Closed
lars-reimann opened this issue Mar 22, 2023 · 1 comment · Fixed by #77
Closed

Metrics as methods of models #64

lars-reimann opened this issue Mar 22, 2023 · 1 comment · Fixed by #77
Assignees
@lars-reimann
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

In some sense metrics are a property of models (in connection with some data).

Desired solution

Think about whether it makes sense to have them as methods on models. This should be easy to implement once #60 is done.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

If this gets implemented, #63 is no longer needed.
@lars-reimann lars-reimann added enhancement 💡 New feature or request cleanup 🧹 Refactorings and other tasks that improve the code and removed enhancement 💡 New feature or request labels Mar 22, 2023
@lars-reimann lars-reimann mentioned this issue Mar 23, 2023
Closed
@lars-reimann lars-reimann self-assigned this Mar 24, 2023
This was referenced Mar 24, 2023
Closed
Merged
@lars-reimann lars-reimann linked a pull request Mar 24, 2023 that will close this issue
feat: metrics as methods of models #77
Merged
lars-reimann added a commit that referenced this issue Mar 24, 2023
@lars-reimann
feat: metrics as methods of models (#77)
bc63693 
Closes #64.

### Summary of Changes

Metrics are now methods of classifiers and regressors. They also take a
validation or test set as input now instead of two columns representing
predicated and expected values.

---------

Co-authored-by: lars-reimann <lars-reimann@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Mar 26, 2023
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
187bbf4 
## [0.4.0](v0.3.0...v0.4.0) (2023-03-26)

### Features

* better names for properties of `TaggedTable` ([#74](#74)) ([fee398b](fee398b))
* change the name of a `Column` ([#76](#76)) ([ec539eb](ec539eb))
* metrics as methods of models ([#77](#77)) ([bc63693](bc63693)), closes [#64](#64)
* optionally pass type to column ([#79](#79)) ([64aa429](64aa429)), closes [#78](#78)
* remove `target_name` parameter of `predict` ([#70](#70)) ([b513454](b513454)), closes [#9](#9)
* rename `tagged_table` parameter of `fit` to `training_set` ([#71](#71)) ([8655521](8655521))
* return `TaggedTable` from `predict` ([#73](#73)) ([5d5f5a6](5d5f5a6))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: metrics as methods of models Safe-DS/Library
1 participant
@lars-reimann