Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally pass type to Column #78

Closed
lars-reimann opened this issue Mar 25, 2023 · 1 comment · Fixed by #79
Closed

Optionally pass type to Column #78

lars-reimann opened this issue Mar 25, 2023 · 1 comment · Fixed by #79
Assignees
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

For Tables we can optionally pass a schema. For Columns the type is always inferred. This is not consistent.

Desired solution

Add an optional parameter to the Column constructor for the type of the Column. If it's passed, we accept it. Otherwise, we infer the type as before.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Mar 25, 2023
@lars-reimann lars-reimann self-assigned this Mar 25, 2023
@lars-reimann lars-reimann linked a pull request Mar 25, 2023 that will close this issue
lars-reimann added a commit that referenced this issue Mar 25, 2023
Closes #78.

### Summary of Changes

For the sake of consistency it is now possible to pass the type of a
`Column` in the constructor. This also improves performance, for example
when we call `get_column` on a `Table`. In that case we already know the
type of the column anyway, so there's no reason to infer it again.

---------

Co-authored-by: lars-reimann <lars-reimann@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Mar 26, 2023
## [0.4.0](v0.3.0...v0.4.0) (2023-03-26)

### Features

* better names for properties of `TaggedTable` ([#74](#74)) ([fee398b](fee398b))
* change the name of a `Column` ([#76](#76)) ([ec539eb](ec539eb))
* metrics as methods of models ([#77](#77)) ([bc63693](bc63693)), closes [#64](#64)
* optionally pass type to column ([#79](#79)) ([64aa429](64aa429)), closes [#78](#78)
* remove `target_name` parameter of `predict` ([#70](#70)) ([b513454](b513454)), closes [#9](#9)
* rename `tagged_table` parameter of `fit` to `training_set` ([#71](#71)) ([8655521](8655521))
* return `TaggedTable` from `predict` ([#73](#73)) ([5d5f5a6](5d5f5a6))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request released Included in a release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant