feat: is_fitted is now always a property
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 66 66
Lines 4825 4852 +27
=========================================
+ Hits 4825 4852 +27 ☔ View full report in Codecov by Sentry. |
lars-reimann
deleted the
586-consistency-is_fitted-as-function-vs-is_fitted-as-attribute
branch
lars-reimann
pushed a commit
that referenced
this pull request
May 1, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-05-01) ### Features * `is_fitted` is now always a property ([#662](#662)) ([b1db881](b1db881)), closes [#586](#586) * add `Column.missing_value_count` ([#682](#682)) ([f084916](f084916)), closes [#642](#642) * Add `InputConversion` & `OutputConversion` for nn interface ([#625](#625)) ([fd723f7](fd723f7)), closes [#621](#621) * Add hash,eq and sizeof in ForwardLayer ([#634](#634)) ([72f7fde](72f7fde)), closes [#633](#633) * allow using tables that already contain target for prediction ([#687](#687)) ([e9f1cfb](e9f1cfb)), closes [#636](#636) * callback `Row.sort_columns` takes four parameters instead of two tuples ([#683](#683)) ([9c3e3de](9c3e3de)), closes [#584](#584) * rename `group_rows_by` in `Table` to `group_rows` ([#661](#661)) ([c1644b7](c1644b7)), closes [#611](#611) * rename `number_of_column` in `Row` to `number_of_columns` ([#660](#660)) ([0a08296](0a08296)), closes [#646](#646) * rework `TaggedTable` ([#680](#680)) ([db2b613](db2b613)), closes [#647](#647) * show missing value count/ratio in summarized statistics ([#684](#684)) ([74b8a35](74b8a35)), closes [#619](#619) * specify `extras` instead of `features` in `to_tabular_dataset` ([#685](#685)) ([841657f](841657f)), closes [#623](#623) ### Bug Fixes * actually use `kernel` of support vector machines for training ([#681](#681)) ([09c5082](09c5082)), closes [#602](#602) ### Performance Improvements * Faster plot_histograms and more reliable plots ([#659](#659)) ([b5f0a12](b5f0a12))
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #586
Summary of Changes
is_fittedwas sometimes a method and sometimes a property. Now it's always a property.