Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework TaggedTable #680

Merged
merged 21 commits into from
May 1, 2024
Merged

feat: rework TaggedTable #680

merged 21 commits into from
May 1, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 1, 2024

Closes #647

Summary of Changes

  • TaggedTable is now called TabularDataset,
  • It is moved from safeds.data.tabular.containers to safeds.data.labeled.containers. That's where all dataset classes for supervised learning will go, like the upcoming ImageDataset.
  • TabularDataset no longer inherits from Table.
  • TabularDataset now has a very small interface. It's only meant to be used as input for supervised ML models. Table manipulation is now solely done using the Table class.
  • tag_columns on Table is now called to_tabular_dataset. This makes it consistent with other conversion methods and emphasizes that this is a terminal operation and should only be used once one is done manipulating the table.
  • TabularDataset now has a public to_table method to get a Table again.

@lars-reimann lars-reimann linked an issue May 1, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented May 1, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 2 0 1.64s
✅ PYTHON black 73 0 0 2.41s
✅ PYTHON mypy 73 0 3.85s
✅ PYTHON ruff 73 0 0 0.25s
✅ REPOSITORY git_diff yes no 0.38s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72842dd) to head (ca56508).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        67    +1     
  Lines         4869      4824   -45     
=========================================
- Hits          4869      4824   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 1, 2024 15:06
@lars-reimann lars-reimann requested a review from a team as a code owner May 1, 2024 15:06
@lars-reimann lars-reimann merged commit db2b613 into main May 1, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 647-simplify-taggedtable branch May 1, 2024 15:06
lars-reimann pushed a commit that referenced this pull request May 1, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-05-01)

### Features

* `is_fitted` is now always a property ([#662](#662)) ([b1db881](b1db881)), closes [#586](#586)
* add `Column.missing_value_count` ([#682](#682)) ([f084916](f084916)), closes [#642](#642)
* Add `InputConversion` & `OutputConversion` for nn interface ([#625](#625)) ([fd723f7](fd723f7)), closes [#621](#621)
* Add hash,eq and sizeof in ForwardLayer ([#634](#634)) ([72f7fde](72f7fde)), closes [#633](#633)
* allow using tables that already contain target for prediction ([#687](#687)) ([e9f1cfb](e9f1cfb)), closes [#636](#636)
* callback `Row.sort_columns` takes four parameters instead of two tuples ([#683](#683)) ([9c3e3de](9c3e3de)), closes [#584](#584)
* rename `group_rows_by` in `Table` to `group_rows` ([#661](#661)) ([c1644b7](c1644b7)), closes [#611](#611)
* rename `number_of_column` in `Row` to `number_of_columns` ([#660](#660)) ([0a08296](0a08296)), closes [#646](#646)
* rework `TaggedTable` ([#680](#680)) ([db2b613](db2b613)), closes [#647](#647)
* show missing value count/ratio in summarized statistics ([#684](#684)) ([74b8a35](74b8a35)), closes [#619](#619)
* specify `extras` instead of `features` in `to_tabular_dataset` ([#685](#685)) ([841657f](841657f)), closes [#623](#623)

### Bug Fixes

* actually use `kernel` of support vector machines for training ([#681](#681)) ([09c5082](09c5082)), closes [#602](#602)

### Performance Improvements

* Faster plot_histograms and more reliable plots ([#659](#659)) ([b5f0a12](b5f0a12))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify TaggedTable
2 participants