feat: remove target_name parameter of predict
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 91.68% 91.56% -0.13%
==========================================
Files 46 46
Lines 1155 1138 -17
==========================================
- Hits 1059 1042 -17
Misses 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lars-reimann
pushed a commit
that referenced
this pull request
Mar 26, 2023
## [0.4.0](v0.3.0...v0.4.0) (2023-03-26) ### Features * better names for properties of `TaggedTable` ([#74](#74)) ([fee398b](fee398b)) * change the name of a `Column` ([#76](#76)) ([ec539eb](ec539eb)) * metrics as methods of models ([#77](#77)) ([bc63693](bc63693)), closes [#64](#64) * optionally pass type to column ([#79](#79)) ([64aa429](64aa429)), closes [#78](#78) * remove `target_name` parameter of `predict` ([#70](#70)) ([b513454](b513454)), closes [#9](#9) * rename `tagged_table` parameter of `fit` to `training_set` ([#71](#71)) ([8655521](8655521)) * return `TaggedTable` from `predict` ([#73](#73)) ([5d5f5a6](5d5f5a6))
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This can also be accomplished by renaming columns in the returned table. If the input table already contains the column we want to predict, it's an indicator for #9, so we shouldn't just let people change the name here.