Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting multiple files for upload not working macOS #29

Closed
Krisell opened this issue Nov 1, 2018 · 7 comments
Closed

Selecting multiple files for upload not working macOS #29

Krisell opened this issue Nov 1, 2018 · 7 comments
Labels
please test The issue was solved in a beta/preview version, please test if it works for you.

Comments

@Krisell
Copy link
Contributor

Krisell commented Nov 1, 2018

Steps to reproduce the problem
Use SEB to go to any page which uses a file input-field with the multiple-attribute, for instance https://smallpdf.com/merge-pdf

What's the problem
Multiple files can't be selected.

What is supposed to happen
Multiple files should be selectable, using cmd or shift, or dragging mouse. This works as expected in any other browser I've tried, including SEB for Windows.

@Krisell Krisell changed the title Multiple files for upload not working on macOS Selecting multiple files for upload not working macOS Nov 1, 2018
@danschlet danschlet added the in roadmap A solution for the issue is planed for upcoming versions. label Aug 8, 2019
@danschlet danschlet added in development A solution for this issue is currently being developed. please test The issue was solved in a beta/preview version, please test if it works for you. and removed in roadmap A solution for the issue is planed for upcoming versions. in development A solution for this issue is currently being developed. labels Sep 18, 2019
@danschlet
Copy link
Member

This is fixed in the final pre-release build of SEB 2.1.4 (will be available in the testing repository later today).

@Krisell
Copy link
Contributor Author

Krisell commented Sep 20, 2019

I tried with 2.1.4pre3 (which I guess is not the latest version) and the issue remains. I also noticed another closely related issue that I've not noticed before, or that's been introduced now. The filtering of types based on the "accept-attribute" (e.g. accept="audio/*") is not respected. I compared this with Safari outside of SEB which behaves as expected.

@danschlet
Copy link
Member

Yes, something more urgent came up yesterday and I couldn't work on the last remaining issues. I hope the final build will be available by Monday.

I have to see if the WebKit framework has an API for that accept-attribute. You can't compare everything to Safari, Apple doesn't give developers full access to all WebKit features. I also still have to use WebKit 1 instead of 2 in Safari, as again not all necessary features are supported in the newer WKWebView. And SEB is an exam browser, I don't care if some convenience parameters aren't yet supported if there are way more important features which we need to implement first...

@Krisell
Copy link
Contributor Author

Krisell commented Sep 20, 2019

I absolutely understand. It is by no means criticism, only notes about discrepancies from other browsers and the standard, (what else should I compare against?) and I’m guessing you’d rather have issues reported than not?

These are both nice to have features and should not be prioritized above most other development, but I don’t know if it’s a matter of one setting, or 100 lines of code.

@Krisell Krisell closed this as completed Sep 20, 2019
@Krisell Krisell reopened this Sep 20, 2019
@danschlet
Copy link
Member

danschlet commented Sep 20, 2019

You're right, better to report even minor issues. We SEB developers sometimes don't even realize that there is something missing (like this accept-attribute), as we're desktop/mobile application developers and not web developers. My comment was just meant to explain why not everything in SEB works like in a regular browser and why that we have to set priorities.

@danschlet
Copy link
Member

The new testing build 2.1.4pre4 with this issue fixes is now available (I had to spend some time fixing also the Touch Bar disabling feature).

Unfortunately the classic WebKit framework doesn't seem to offer an API for that accept-attribute. I will look into a possible workaround when implementing the new WebKit (WKWebView).

@Krisell
Copy link
Contributor Author

Krisell commented Oct 2, 2019

Thank you, it does work now. Great job!

I also noticed the information about the touch bar not being reset, which I was just about to file a bug report for. Nice!

@Krisell Krisell closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test The issue was solved in a beta/preview version, please test if it works for you.
Projects
None yet
Development

No branches or pull requests

2 participants