Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOWS-394] Add TowerViewer roles ahead of sandbox deprecation #125

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

BrunoGrandePhD
Copy link
Contributor

@BrunoGrandePhD BrunoGrandePhD commented Aug 12, 2022

I'm adding everyone's TowerViewer roles first to confirm that everyone can access their S3 buckets before removing their sandbox developer roles. I'll perform that step in a separate PR.

@BrunoGrandePhD BrunoGrandePhD marked this pull request as ready for review August 22, 2022 22:36
@BrunoGrandePhD BrunoGrandePhD requested a review from a team as a code owner August 22, 2022 22:36
Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just re-confirming that all the amp-ad resources should fall under the strides roles.

@BrunoGrandePhD
Copy link
Contributor Author

I'm relying on the resource-based policies on the buckets to grant S3 access. So, these roles need to be in the same account as the bucket. Otherwise, you have need to set up cross-account access, which requires the IAM roles to gain S3 permissions, which gets complicated fast.

@BrunoGrandePhD BrunoGrandePhD merged commit 6d92b89 into main Aug 23, 2022
@BrunoGrandePhD BrunoGrandePhD deleted the bgrande/WORKFLOWS-394/deprecate-sandbox-roles branch August 23, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants