Develop #453
Closed
Develop #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the force service to the core module - Moved all PrimeNG references to the shared module - Refactored the shared module imports for other modules - Added two fields to the team member model - Changed the way that the contribute teams page load all the images, before we had to wait for requests and now we make all the requests in parallel - Related to #375
- Changed the way the images are loaded in the contrib page, now they load async - Allowed the contributing teams page to gradually render images that are downloaded, and using a placeholder while waiting - Related to #375
- Fixed a resizing error in the genes list component - Moved more methods to the api service - Changed calls in several components to use the new api methods - Moved all the loading logic into the a new data service method - Added parallel loading to the data service when loading chart data
Change badge to travis-ci.org
Update README.md
- Fixed wrong colors and icon position in the multiselect component - Fixed wrong colors and icon position in the checkbox component - Added new images to fix design issues - Added an image for the nominated gene button, synapse account creation - Added a plus and minus icons - Fixed an issue with mobile modals - Closes #386 - Closes #388 - Closes #389 - Closes #391
* 'develop' of github.com:Sage-Bionetworks/Agora: Fixing more styling issues
- Fixed a filter problem with the selectMenu chart when loading the same gene twice - Fixed left space clipping values in the forest plot - Added the ability to load the same gene from list or search without reloading the data - Changed the gene overview tests to reflect the new functionalities - Changed the gene service and gene service stub to reflect the changes - Closes #395 - Closes #403 - Closes #406
- Moved icons to the icons asset folder - Changed the default checked icon to the image used in the Figma design - Fixed the incorrect Y padding with the box plot chart - Added a link from Druggability in the Summary of Evidence to the Next Steps section of the page - Added a new package, ngx-page-scroll - Closes #381 - Closes #401
- Fixes a bug when reloading the same gene using the browser history button - Closes #403
- Fixed a loading issue preventing information to get rendered properly - Changed a few api endpoints return values that were faulty - Changed a few design things related to the network widget - Fixed the column position for the network widget when there is no expression data - Closes #414
* Setup automated docker container deployments to the official Sage dockerhub repository at https://hub.docker.com/u/sagebionetworks/dashboard/ * Split CI builds into separate stages * Setup Agora tests to run against the built and deployed agora containers in dockerhub 'sagebionetworks' org. This validates the container builds and deployments.
Docker deployments to dockerhub
* 'develop' of github.com:Sage-Bionetworks/Agora: Docker deployments to dockerhub
- Added basic tests to several components
Create a separate CI stage for tests.
- Removes the end of the text after RefSeq, or variances in the genes description - Added a inner section divider so prevent user confusion - Fixed an incorrect text display for the nomination of a target gene in the gene network component - Added visual feedback when searching genes - Added a new response interface type GeneInfosResponse - Changed the info icon to use the new design in Fimga - Fixed an issue with the BETA text not being bold - Updated vulnerable packages - Bumped data version to 8 - Closes #412 - Closes #413 - Closes #425 - Closes #428 - Closes #429 - Related to #433
Starting nginx container in a t2.large EC2 would result in error "20000 worker_connections exceed open file resource limit: 1024" Update nginx configs to allow it to startup without error.
* 'develop' of github.com:Sage-Bionetworks/Agora: Adding alphabetical order to the teams page tune nginx for AWS # Conflicts: # src/app/genes/gene-details/gene-similar/gene-similar.component.ts
- Added a hotfix to the teams ordering, images were correct but teams weren't
conditionally build client according to environment
This caused invalid yaml exception. This reverts commit a0c6a78.
This reverts commit 35dce39.
conditional environment builds of agora
* 'develop' of github.com:Sage-Bionetworks/Agora: fix conditional build on beanstalk ec2 Revert "Revert "conditionally build client according to environment""
* 'develop' of github.com:Sage-Bionetworks/Agora: Small fix removing linebreak from local download script
- Added X axis labels to the box plot - Added a new tooltip to the brain tissues in the X axis on the forest plot - Added the model above the forest-plot - Closes #556
- Removed the duplicated charts - Removed duplicated tooltips - Closes #558
AWS support says that the script is trying to delete a file that that doesn't exist. Their suggestion is to ddd some logic to only delete if file exists.
Attempt to fix nginx retart error
This time AWS support suggests using initctl instead of service command. FROM AWS SUPPORT: I have done some research on the issue and have found that it is an ongoing issue with the node.js environment and the cause for the issue all node.js environment greater than equal to 4.4.6 version is reporting an error in service nginx restart. I have found that instead of service command they are now using the initctl for starting and stopping the nginx service.
another attempt to fix nginx restart
command arguements need to be in correct order
another attempt at nginx restart fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.