Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN-628] Update PFS status variables #114

Merged
merged 7 commits into from
Apr 11, 2023
Merged

[GEN-628] Update PFS status variables #114

merged 7 commits into from
Apr 11, 2023

Conversation

thomasyu888
Copy link
Member

@thomasyu888 thomasyu888 commented Apr 8, 2023 •
edited
Loading

  • Make sure PFS status variables are remapped to the correct values
  • Use convenience functions for the remapping
  • Only BLADDER supports TIMELINE-PERFORMANCE right now

@thomasyu888 thomasyu888 requested a review from a team as a code owner April 8, 2023 22:41
Chelsea-Na
Chelsea-Na reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@Chelsea-Na Chelsea-Na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor spelling mistakes may be present.

geniesp/bpc_config.py Outdated Show resolved Hide resolved
geniesp/bpc_redcap_export_mapping.py Show resolved Hide resolved
thomasyu888
thomasyu888 commented Apr 11, 2023
View reviewed changes
geniesp/bpc_config.py Outdated Show resolved Hide resolved
@thomasyu888 thomasyu888 merged commit 16356ad into develop Apr 11, 2023
@thomasyu888 thomasyu888 deleted the GEN-628-pfs-status-variables branch April 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chelsea-Na Chelsea-Na Chelsea-Na approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasyu888 @Chelsea-Na