Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1283] Replace Broken Link URL #989

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[SYNPY-1283] Replace Broken Link URL #989

merged 2 commits into from
Oct 20, 2023

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Oct 19, 2023 •
edited
Loading

This PR replaces a broken URL with the correct one pointing to the documentation of synapseutils.sync.syncToSynapse in `main.py.

@pep8speaks
Copy link

pep8speaks commented Oct 19, 2023 •
edited
Loading

Hello @BWMac! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 940:89: E501 line too long (142 > 88 characters)

Comment last updated at 2023-10-19 21:47:55 UTC

@BWMac BWMac marked this pull request as ready for review October 19, 2023 21:49
@BWMac BWMac requested a review from a team as a code owner October 19, 2023 21:49
BryanFauble
BryanFauble approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BWMac BWMac merged commit f2a4a40 into develop Oct 20, 2023
32 of 35 checks passed
@BWMac BWMac deleted the bwmac/SYNPY-1283/fix-broken-link branch October 20, 2023 15:14
@BWMac BWMac restored the bwmac/SYNPY-1283/fix-broken-link branch October 23, 2023 14:40
@BWMac BWMac mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BWMac @pep8speaks @BryanFauble