Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1283] Adds Missing Trailing Space (Broken Link Fix) #991

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[SYNPY-1283] Adds Missing Trailing Space (Broken Link Fix) #991

merged 1 commit into from
Oct 23, 2023

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Oct 23, 2023 •
edited
Loading

This PR follows-on from #989 to add a trailing space to the URL that I replaced earlier.

image-20231021-011604

@pep8speaks
Copy link

Hello @BWMac! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 940:89: E501 line too long (143 > 88 characters)

@BWMac BWMac marked this pull request as ready for review October 23, 2023 14:45
@BWMac BWMac requested a review from a team as a code owner October 23, 2023 14:45
BryanFauble
BryanFauble approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM - I rebuilt the docs/html with make clean && make html and verified the docs looks good.

@BryanFauble BryanFauble merged commit e0ba3d4 into develop Oct 23, 2023
31 of 35 checks passed
@BWMac BWMac deleted the bwmac/SYNPY-1283/fix-broken-link branch January 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

@thomasyu888 thomasyu888 Awaiting requested review from thomasyu888

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BWMac @pep8speaks @BryanFauble