Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNR-1466 upgrade markupsafe #290

Merged

Conversation

jkiang13
Copy link
Contributor

@jkiang13 jkiang13 commented Oct 14, 2020

https://sagebionetworks.jira.com/browse/SYNR-1466

Upgrades MarkupSafe (and Jinja2) version dependencies used. MarkupSafe 1.0 has an issue with some versions of setuptools. Normally this isn't an issue with the setuptools version that is bundled with the embedded python 3.6.8, but if the user e.g. has another setuptools in their user site packages directory in sys.path overriding it it can cause an installation failure.

@jkiang13 jkiang13 changed the base branch from master to develop October 14, 2020 17:15
Copy link
Member

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@brucehoff brucehoff merged commit 9abf0cf into Sage-Bionetworks:develop Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants