Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi action button has an aria-label of "show more" #6397

Closed
1 task done
niamhmadden24 opened this issue Oct 30, 2023 · 2 comments · Fixed by #6417
Closed
1 task done

Multi action button has an aria-label of "show more" #6397

niamhmadden24 opened this issue Oct 30, 2023 · 2 comments · Fixed by #6417
Labels
Bug multi-action-button On Backlog released Squad Nebula

Comments

@niamhmadden24
Copy link

Current behaviour

the MultiActionButton component has an aria-label of "Show more" added by default. This is causing problems for speech recognition software as the accessible name often won't match the visible text of the button. It also reads out "show more" for the button value when using a screen reader, which won't give users context of what the button is.

Expected behaviour

Remove default aria-label and allow the accessible name to be drawn from the button value.

CodeSandbox or Storybook URL

https://codesandbox.io/s/currying-rain-mpx2r4?file=/src/App.tsx

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

123.1.0

Design Tokens Version

No response

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@niamhmadden24 niamhmadden24 added Bug triage Triage Required labels Oct 30, 2023
@nicktitchmarsh
Copy link
Contributor

FE-6261

tomdavies73 added a commit that referenced this issue Nov 8, 2023
@tomdavies73
fix(multi-action-button): remove unnecessary aria-label
942f43a 
fix #6397
@tomdavies73 tomdavies73 mentioned this issue Nov 8, 2023
Merged
15 tasks
carbonci pushed a commit that referenced this issue Nov 15, 2023
@semantic-release-bot @carbonci
chore(release): 123.8.0
b82dff8 
## [123.8.0](v123.7.2...v123.8.0) (2023-11-15)

### Features

* **split-button:** add aria-label prop and locale support for aria-label ([aedafe8](aedafe8))

### Bug Fixes

* **multi-action-button:** remove unnecessary aria-label ([942f43a](942f43a)), closes [#6397](#6397)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 123.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug multi-action-button On Backlog released Squad Nebula
Milestone
No milestone
3 participants
@carbonci @nicktitchmarsh @niamhmadden24