-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StepFlow - change title prop type #6732
Comments
@tempertemper would this be an acceptable enhancement for us to make, I believe you previously steered to limit it to just a subset of heading elements but there may be use cases that call for loosening that? |
Is this to add an icon into the |
@tempertemper Yes. Our use case is to use an icon in the header. |
FE-6644 |
adds the 'titleNodeLeft' and 'titleNodeRight' props to provide consumers with the means to render a node before or after the `SepFlow` title. To be used to provide users with additional title context and information fix #6732
the sub component `StepFlowTitle` has been created to enable consumers to use a compositional approach, and render custom title content. Consumers can now pass a node to the `title` prop and pass any relevant elements to achieve designs and meet requirements - as well as the `StepFlowTitle` within that node, to ensure the component still functions correctly. Within the `StepFlowTitle` sub component, consumers can pass the `titleString` prop to override the text children, `titleVariant` to change the heading level between h1 and h2 and the `screenReaderOnlyTitle` to provide an alternative screen reader only title. This is useful if added information or context needs to be added to the title, especially if other elements have now been rendered in the node passed to the `title` prop. fix #6732
the sub component `StepFlowTitle` has been created to enable consumers to use a compositional approach, and render custom title content. Consumers can now pass a node to the `title` prop and pass any relevant elements to achieve designs and meet requirements - as well as the `StepFlowTitle` within that node, to ensure the component still functions correctly. Within the `StepFlowTitle` sub component, consumers can pass the `titleString` prop to override the text children, `titleVariant` to change the heading level between h1 and h2 and the `screenReaderOnlyTitle` to provide an alternative screen reader only title. This is useful if added information or context needs to be added to the title, especially if other elements have now been rendered in the node passed to the `title` prop. fix #6732
## [141.2.0](v141.1.1...v141.2.0) (2024-07-29) ### Features * **step-flow:** allow component title to be compositional ([4d5d808](4d5d808)), closes [#6732](#6732)
🎉 This issue has been resolved in version 141.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Dialog’s title prop can be an Element and we use it to display an icon next to the title when the action is destructive.
We are now introducing StepFlow in Dialogs but StepFlow’s title is only a string.
Suggested solution
Make StepFlow's title prop accept an Element
Demo URL
No response
Alternatives
No response
Additional context
No response
Confidentiality
The text was updated successfully, but these errors were encountered: