-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(date): rfc proposing new date component #4294
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59353fb:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good to me in general, mostly minor comments/changes from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update RFC to use composition for date picker e.g.
<Date picker={<Picker />} />
18da94c
to
bab1c9e
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Looks good to me, I'm just not sure about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meeting Notes 30th Sept
Attendees: @edleeks87 @mkrds
- Change
renderPicker
to bepickerProps
and pass props toreact-day-picker
- Link to
react-day-picker
documentation - Add notes on
captionElement
. We will add additional prop e.g.displayInputCaption
which will add ourSelect
components for switching the month/year.
bab1c9e
to
c57dead
Compare
c57dead
to
63bc5b8
Compare
b5a4038
to
36f5492
Compare
3d873ec
6ff4b61
to
3d873ec
Compare
PR has moved into final comments stage, this PR will be merged in 3 days time if no further changes are required |
2563f88
to
ff1c00f
Compare
🎉 This PR is included in version 97.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Regarding alternatives to Since |
Proposed behaviour
RFC detailing a proposal for a new implementation for the
Date
componentCurrent behaviour
Existing implementation has considerable technical debt and issues and pending features
Checklist
Additional context
POC (very rough implementation):
https://codesandbox.io/s/poc-of-rfc-proposal-ctdfw?file=/src/index.js
Testing instructions