-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(button-toggle): remove deprecated props and convert enzyme tests to RTL #6747
Conversation
Removes deprecated `checked` prop from `ButtonToggle`. BREAKING CHANGE: `checked` prop has been removed, `pressed` should be used instead.
Removes deprecated `name` prop from `ButtonToggle` and `ButtonToggleGroup`, `onChange` type has also been updated as a result. BREAKING CHANGE: `name` prop has been removed, `onChange` prop type as also been updated as a result.
1e8205c
to
fb2575f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from me. Great job on this @nuria1110, especially with using more accessible RTL queries wherever possible 👍🏼
src/components/button-toggle/button-toggle-group/button-toggle-group.test.tsx
Outdated
Show resolved
Hide resolved
src/components/button-toggle/button-toggle-group/button-toggle-group.test.tsx
Outdated
Show resolved
Hide resolved
src/components/button-toggle/button-toggle-group/button-toggle-group.test.tsx
Show resolved
Hide resolved
src/components/button-toggle/button-toggle-group/button-toggle-group.test.tsx
Outdated
Show resolved
Hide resolved
src/components/button-toggle/button-toggle-group/button-toggle-group.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add that @Parsium hasn't already raised, I don't completely agree with the suggested description updates but I think slight tweaks to them is worthwhile
fb2575f
to
2eda196
Compare
🎉 This PR is included in version 138.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
checked
prop from ButtonToggle.name
prop from ButtonToggle and ButtonToggleGroup.onChange
prop no longer hasname
in type.Current behaviour
checked
prop is deprecated.name
prop is deprecated.Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions