Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videocall setting changes #2445

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Videocall setting changes #2445

merged 3 commits into from
Apr 9, 2024

Conversation

umairkhannn
Copy link
Member

  • Change the settings menu to "Layout" and change the icon to the grid icon
  • Add a new "Settings" menu that opens the menu available through "Module settings" (which should be removed from the settings menu)
  • Make "Screen Share" it's own icon next to broadcast and record
  • Change the title of the old settings menu to 'Layout' and update the HTML of the options to match the standard modal menus. (We want to be able to update the theme universally and update all overlay menus)

Screenshot from 2024-04-05 06-31-31

@umairkhannn umairkhannn linked an issue Apr 5, 2024 that may be closed by this pull request
4 tasks
@umairkhannn umairkhannn requested a review from arpee April 5, 2024 01:38
@arpee
Copy link
Member

arpee commented Apr 5, 2024

image

Lack of background here on overlay confusing.

Also - we should standardise on a single method of showing what is selected in menus... we have several different methods now - (theme menu for example).

Let me think on which we should standardise to. Just pointing out here.

@umairkhannn
Copy link
Member Author

Fixed background.

Screenshot from 2024-04-05 11-31-34

Agreed.

"we should standardise on a single method of showing what is selected in menus."

@arpee arpee merged commit 8c97dbf into staging Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Rectify' videocall settings menu
2 participants