Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strict validation to phone number as an option #59

Merged
merged 2 commits into from
Sep 25, 2019
Merged

feat: add strict validation to phone number as an option #59

merged 2 commits into from
Sep 25, 2019

Conversation

optii
Copy link
Contributor

@optii optii commented Aug 20, 2019

Resolves #57.

Adds an option strict to define if isValidNumber should be checked against the formatted number.

This is a quick first draft, will need to update the README.md & add some more tests.

Let me know

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 14e0270 on optii:feature/strict into 9ca9edc on Salesflare:master.

@coveralls
Copy link

coveralls commented Aug 20, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 514a9fd on optii:feature/strict into 9ca9edc on Salesflare:master.

@iraycd
Copy link

iraycd commented Aug 23, 2019

Merge this please.

@AdriVanHoudt
Copy link
Contributor

I like the solution! Thanks for this!
If you can add some more test and update the readme I will gladly merge this ✨

@CatGuardian
Copy link

How is this coming along @optii? Are we getting close to having this wrapped up?

@optii
Copy link
Contributor Author

optii commented Sep 25, 2019

Just pushed some updates, I've updated the test, to use the examples given in issue #57, a bit stuck as to what other test i could possibly add tbh. Added the example to the readme, don't know if how I've done it is what you where expecting ? happy to make changes if you've got any suggestions

@AdriVanHoudt AdriVanHoudt merged commit ca9bbee into Salesflare:master Sep 25, 2019
@AdriVanHoudt
Copy link
Contributor

Thanks for this!
Released under 3.1.0 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Doesn't Use The Phone Utility's isValidNumber() Method
5 participants