Wrong import path for PD types #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavery
force-pushed
the
bugfix/import-path-pd-core
branch
from
412e3e6
to
036a2c1
Compare
alexvuong
approved these changes
Sep 14, 2023
wjhsf
approved these changes
Sep 18, 2023
|
Thanks @clavery 🙏 |
bfeister
added a commit
that referenced
this pull request
Sep 22, 2023
- Cleanup wrong import path for page-designer component [#1441](#1441) @clavery - Modularize country code source for targeting via extensibility [#1445](#1445) @bfeister - Export icon helper function for target via overrides [#1420](#1420) @cbrother-csu - Migrate Page Designer core types to commerce-sdk-react [#1441](#1441) @clavery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This import references modules that are no longer there. Were moved to commerce-sdk-react
Description
This index file isn't even used so probably can be removed instead of fixing this import.
Types of Changes
Changes
How to Test-Drive This PR
Accessibility Compliance
You must check off all items in one of the follow two lists: