@W-14146843@ modularize country code source for targeting via extensibility #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcua-mobify
previously approved these changes
Sep 19, 2023
alexvuong
previously approved these changes
Sep 19, 2023
bfeister
force-pushed
the
feature/@W-14146843@
branch
from
05937d7
to
1a0fe8b
Compare
wjhsf
previously approved these changes
Sep 19, 2023
bfeister
dismissed stale reviews from wjhsf, alexvuong, and vcua-mobify
via
1322ff5
alexvuong
reviewed
Sep 19, 2023
packages/template-retail-react-app/app/components/forms/useAddressFields.jsx
Outdated
Show resolved
Hide resolved
wjhsf
approved these changes
Sep 19, 2023
alexvuong
approved these changes
Sep 19, 2023
bfeister
added a commit
that referenced
this pull request
Sep 22, 2023
…6843@ @W-14146843@ modularize country code source for targeting via extensibility
bfeister
added a commit
that referenced
this pull request
Sep 22, 2023
- Cleanup wrong import path for page-designer component [#1441](#1441) @clavery - Modularize country code source for targeting via extensibility [#1445](#1445) @bfeister - Export icon helper function for target via overrides [#1420](#1420) @cbrother-csu - Migrate Page Designer core types to commerce-sdk-react [#1441](#1441) @clavery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
useAddressFields.jsxhas a hardcoded value for theoptionsdropdown. This means that you can't expand the country options without overriding the whole file (a pattern we want to avoid for making better use of the Template Extensibility feature!)This request comes from the Adyen team who need to be able to extend this file without overriding this whole file in their accelerator (which would be bad!)
Note that we want to make small changes like this iteratively and not be shy about gradually "decomposing" the app code structure gradually over time
Closes #1408
Types of Changes
Changes
How to Test-Drive This PR
address-fields-country-codes.jsxcountry listChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization