v2 fix old naming #521
Merged
v2 fix old naming #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraya
reviewed
Apr 18, 2022
wjhsf
reviewed
Apr 19, 2022
adamraya
reviewed
Apr 20, 2022
There was a problem hiding this comment.
I found one more reference to the old repo on the Circle CI Status badge.
Do you want to update it with the pwa-kit repo?
Following the Circle CI docs it will be something like:
[](https://nodei.co/npm/pwa-kit-react-sdk/) [](https://circleci.com/gh/SalesforceCommerceCloud/pwa-kit)
adamraya
approved these changes
Apr 20, 2022
This was referenced Apr 26, 2022
adamraya
added a commit
that referenced
this pull request
Apr 26, 2022
* Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * bump 2.0.0-dev.4 (#502) * bump * fix version * Optimize visibility-off.svg (#512) * [V2] Rename 'pwa' directory into 'template-retail-react-app' (#485) * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa-kit-build package and mrt CLI to pwa-kit-cli (package + CLI) (#481) * Rename pwa-kit-build/mrt to sf-mrt. * Rename sf-mrt to pwa-kit-cli * Rename mrt file to cli * Rename sf-mrt directory to pwa-kit-cli * Use pwa-kit-cli instead of pwa-kit-build. * Move loading screen from pwa-kit-build to pwa-kit-cli * Update CLI human-readable name. * [V2] Reinstate `pwa-kit-build` Test(s) (#492) * Reinstate build test * Add regenerator-runtime to internal-lib-build Co-authored-by: vcua-mobify <vcua@salesforce.com> * [V2]Generate different reports for different bundles (#508) * generate different reports for different bundles * fix report bundle size script * Remove old config implementation from bad merge (#513) * [V2] Re-Enable Windows Node 14 CI Workflow (#487) * Re-enable windows node 14 workflow * Fix glob string cross environment * Testing removing restore_cache * Testing forceExit flag * Testing not running lint * Debugging using double quotes * Force crlf line ending for mrt.js file * Revert "Force crlf line ending for mrt.js file" This reverts commit b249e0f. * Test not running tests on templates * Re-enable lint * Testing adding eslint at root * Revert "Testing adding eslint at root" This reverts commit 531fe6a. * clean up * Try again crlf on mrt.js * Revert "Try again crlf on mrt.js" This reverts commit 301826c. * Lint fix template-typescript-minimal * Enable eslint debug flag * Remove silent flag * Enable eslint debug flag for internal-lib-build * Fix glob string cross env on internal-lib-build script * Remove lerna parallel flag on lint script * Remove eslint debug flags * Exclude tsx files from lint * Debug mrt eslint * Re-enable eslint debug flags * Testing Windows xlarge * Fix mrt pkgRoot * Print more logs * Testing npm ci on Windows * Clean up * Testing lerna link * Add lerna link to setup_windows circle ci step * Add docs to Circle CI config * typo Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump Verdaccio to latest (#518) * [V2] Fix Circular Dependency Warnings (#514) * Remove CLI dev dependency causing circular dependency warnings Co-authored-by: Oliver Brook <olibrook@gmail.com> * Update copyrights and template. (#516) * v2 fix old naming (#521) * v2 replace old name mobify-platform-sdk references to pwa-kit * fix typo in readme and jsdoc (#530) * [V2] Fix source maps cannot be found when debugging the server (#526) * fix source map not working for server-side debugging * [V2] Loading page: avoid seeing infinite reloads (#532) * [V2] Fix invalid refresh token (#528) * fix tests * fix merge issue * fix test * [V2] Allow pass thru cli options for test command (#537) * Allow jest option to pass thru * remove useless test env * Remove lodash and bluebird. (#534) * Don't count untestable line towards code coverage. * Remove lodash and bluebird. * Oops, a semi! * Revert to util.promisify so tests pass. * Refactor to fix tests. * Fix l10n scripts to use and output to the correct file (#539) This hardcoding of the default locale was done in V1, but it was not done in V2 yet.. until now. * Merge branch `release 2.0.x` into `v2` (#542) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com>
adamraya
added a commit
that referenced
this pull request
Apr 27, 2022
…ev.5` (#547) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Preview release `2.0.0-dev.4` (#544) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * bump 2.0.0-dev.4 (#502) * bump * fix version * Optimize visibility-off.svg (#512) * [V2] Rename 'pwa' directory into 'template-retail-react-app' (#485) * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa-kit-build package and mrt CLI to pwa-kit-cli (package + CLI) (#481) * Rename pwa-kit-build/mrt to sf-mrt. * Rename sf-mrt to pwa-kit-cli * Rename mrt file to cli * Rename sf-mrt directory to pwa-kit-cli * Use pwa-kit-cli instead of pwa-kit-build. * Move loading screen from pwa-kit-build to pwa-kit-cli * Update CLI human-readable name. * [V2] Reinstate `pwa-kit-build` Test(s) (#492) * Reinstate build test * Add regenerator-runtime to internal-lib-build Co-authored-by: vcua-mobify <vcua@salesforce.com> * [V2]Generate different reports for different bundles (#508) * generate different reports for different bundles * fix report bundle size script * Remove old config implementation from bad merge (#513) * [V2] Re-Enable Windows Node 14 CI Workflow (#487) * Re-enable windows node 14 workflow * Fix glob string cross environment * Testing removing restore_cache * Testing forceExit flag * Testing not running lint * Debugging using double quotes * Force crlf line ending for mrt.js file * Revert "Force crlf line ending for mrt.js file" This reverts commit b249e0f. * Test not running tests on templates * Re-enable lint * Testing adding eslint at root * Revert "Testing adding eslint at root" This reverts commit 531fe6a. * clean up * Try again crlf on mrt.js * Revert "Try again crlf on mrt.js" This reverts commit 301826c. * Lint fix template-typescript-minimal * Enable eslint debug flag * Remove silent flag * Enable eslint debug flag for internal-lib-build * Fix glob string cross env on internal-lib-build script * Remove lerna parallel flag on lint script * Remove eslint debug flags * Exclude tsx files from lint * Debug mrt eslint * Re-enable eslint debug flags * Testing Windows xlarge * Fix mrt pkgRoot * Print more logs * Testing npm ci on Windows * Clean up * Testing lerna link * Add lerna link to setup_windows circle ci step * Add docs to Circle CI config * typo Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump Verdaccio to latest (#518) * [V2] Fix Circular Dependency Warnings (#514) * Remove CLI dev dependency causing circular dependency warnings Co-authored-by: Oliver Brook <olibrook@gmail.com> * Update copyrights and template. (#516) * v2 fix old naming (#521) * v2 replace old name mobify-platform-sdk references to pwa-kit * fix typo in readme and jsdoc (#530) * [V2] Fix source maps cannot be found when debugging the server (#526) * fix source map not working for server-side debugging * [V2] Loading page: avoid seeing infinite reloads (#532) * [V2] Fix invalid refresh token (#528) * fix tests * fix merge issue * fix test * [V2] Allow pass thru cli options for test command (#537) * Allow jest option to pass thru * remove useless test env * Remove lodash and bluebird. (#534) * Don't count untestable line towards code coverage. * Remove lodash and bluebird. * Oops, a semi! * Revert to util.promisify so tests pass. * Refactor to fix tests. * Fix l10n scripts to use and output to the correct file (#539) This hardcoding of the default locale was done in V1, but it was not done in V2 yet.. until now. * Merge branch `release 2.0.x` into `v2` (#542) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> * Bump version `2.0.0-dev.5` * Bump root package-lock.json file version to 2.0.0-dev.5 Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace old mobify-platform-sdk ref to pwa-kit
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization