[V2]Generate different reports for different bundles #508

alexvuong · 2022-04-07T23:25:03Z

@W-10921909@

Description

With our current implementation, we have 5 bundles, but they all get generated into a report.html and stat.json. As a result, the old report will be replaced with the new one.

This PR adjust webpack config so it will generate different webpack analyzer report for each bundles

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop

Adding a required argument to a function

Changing the data type of a function parameter or return value

Adding a new peer dependency to package.json

Changes

pwa-kit-build/src/configs/webpack/config.js

How to Test-Drive This PR

run npm run analyzer-build at packages/pwa
Verify that there will be 5 tabs opening for each report.
Verify it works on common browsers like Chrome, Safari, and Firefox. You need to set each as default browser, so the tab will automatically open in those browsers.

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

There are no changes to UI

or...

Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Changes comply with WCAG 2.0 guidelines levels A and AA
Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

Changes include a UI text update in the Retail React App (which requires translation)

packages/pwa-kit-build/src/configs/webpack/config.js

scripts/report-bundle-size.js

packages/pwa-kit-build/src/configs/webpack/config.js

scripts/report-bundle-size.js

packages/pwa-kit-build/src/configs/webpack/config.js

scripts/report-bundle-size.js

packages/pwa-kit-build/src/configs/webpack/config.js

This reverts commit 04eca33.

alexvuong · 2022-04-13T02:21:36Z

packages/pwa-kit-build/src/configs/webpack/config.js

+            },
+            plugins: [
+                ...config.plugins,
+                analyzeBundle && getBundleAnalyzerPlugin('client-optional')


Note: we name this bundle pwa-others, probably need to change it to something more relavant to retail-react-app taking into the account we have changed it to template-retail-react-app

Let's have both the webpack name and the name of analyzer reports to be the same name.

As for which name to use, I think it should be general because this webpack config is meant to be used for other templates too (not just the retail react app). Instead of pwa-others my idea is to use client-optional. We've already name the previous bundle 'client' and this is going to be its optional bundle.

agreed on that, I've changed the bundle name to client-optional for consistency

vmarta · 2022-04-13T16:20:27Z

scripts/report-bundle-size.js

-        const value = bundle.size
-        childProc.spawnSync('dog', ['metric', 'post', metric, value, '--host', bundle.name])
-        console.log(`${metric} ${value} --host ${bundle.name}`)
+    const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')


Suggested change

const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')

const buildDir = path.join(path.resolve(''), 'packages', 'template-retail-react-app', 'build')

Suggested change

const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')

const buildDir = path.resolve('packages', 'template-retail-react-app', 'build')

Mixing path.join and path.resolve isn't necessary.

Good catch. I've made the changes as suggested

vmarta · 2022-04-13T16:21:27Z

scripts/report-bundle-size.js

+    const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')
+    fs.readdir(buildDir, (err, files) => {
+        if (err)
+            console.log(err);


Suggested change

console.log(err);

console.error(err);

I think we can also take this error handling further. How about making it so that it would fail CI?

console.error(err) process.exit(1)

Inspired by

pwa-kit/scripts/check-dependencies.js

Line 275 in 271e82c

process.exit(1)

vmarta · 2022-04-13T16:23:18Z

scripts/report-bundle-size.js

+                // bundle report stats files are name as `*-analyzer-stats.json`
+                if (file.includes('-analyzer-stats.json')) {
+                    console.log(`Analyzer stats json file found:`, file)
+                    const retailReactAppStats = require(path.join(path.resolve(''), 'packages', 'pwa', 'build', file))


We can reuse buildDir here. And please make sure that we're looking in the new template-retail-react-app package.

vmarta · 2022-04-13T16:25:56Z

scripts/report-bundle-size.js

+        if (err)
+            console.log(err);
+        else {
+            files.forEach(file => {


Let's filter the files first:

files .filter((file) => file.includes('-analyzer-stats.json')) .forEach(...)

vmarta · 2022-04-13T16:44:59Z

packages/pwa-kit-build/src/configs/webpack/config.js

+            },
+            plugins: [
+                ...config.plugins,
+                analyzeBundle && getBundleAnalyzerPlugin('client-optional')


Let's have both the webpack name and the name of analyzer reports to be the same name.

As for which name to use, I think it should be general because this webpack config is meant to be used for other templates too (not just the retail react app). Instead of pwa-others my idea is to use client-optional. We've already name the previous bundle 'client' and this is going to be its optional bundle.

wjhsf · 2022-04-13T18:59:52Z

packages/pwa-kit-build/src/configs/webpack/config.js

@@ -214,14 +219,19 @@ const client =
    baseConfig('web')
        .extend(withChunking)
        .extend((config) => {
+            const name = 'client'
            return {
                ...config,
                // Must be named "client". See - https://www.npmjs.com/package/webpack-hot-server-middleware#usage


Is this comment still relevant?

yes it is, it is still being named 'client', I extracted the value to a constant above so I can reuse it below.

wjhsf · 2022-04-13T19:03:19Z

scripts/report-bundle-size.js

-        const value = bundle.size
-        childProc.spawnSync('dog', ['metric', 'post', metric, value, '--host', bundle.name])
-        console.log(`${metric} ${value} --host ${bundle.name}`)
+    const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')


Suggested change

const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')

const buildDir = path.resolve('packages', 'template-retail-react-app', 'build')

Mixing path.join and path.resolve isn't necessary.

wjhsf · 2022-04-13T19:09:19Z

scripts/report-bundle-size.js

-        childProc.spawnSync('dog', ['metric', 'post', metric, value, '--host', bundle.name])
-        console.log(`${metric} ${value} --host ${bundle.name}`)
+    const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')
+    fs.readdir(buildDir, (err, files) => {


Suggested change

fs.readdir(buildDir, (err, files) => {

const files = await fs.promises.readdir(buildDir)

Use promises, not callbacks!

wjhsf · 2022-04-13T19:34:00Z

scripts/report-bundle-size.js

+                    bundles.forEach((bundle) => {
+                        const metric = `mobify_platform_sdks.bundle_size_byte`
+                        const value = bundle.size
+                        childProc.spawnSync('dog', ['metric', 'post', metric, value, '--host', bundle.name])
+                        console.log(`${metric} ${value} --host ${bundle.name}`)
+                    })


Can this be parallelized using spawn instead of spawnSync?

vmarta

+1 from me. Thanks for addressing the feedback.

There's one Ci test that fails, though. I'm not sure what's going on there.

* Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * bump 2.0.0-dev.4 (#502) * bump * fix version * Optimize visibility-off.svg (#512) * [V2] Rename 'pwa' directory into 'template-retail-react-app' (#485) * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa-kit-build package and mrt CLI to pwa-kit-cli (package + CLI) (#481) * Rename pwa-kit-build/mrt to sf-mrt. * Rename sf-mrt to pwa-kit-cli * Rename mrt file to cli * Rename sf-mrt directory to pwa-kit-cli * Use pwa-kit-cli instead of pwa-kit-build. * Move loading screen from pwa-kit-build to pwa-kit-cli * Update CLI human-readable name. * [V2] Reinstate `pwa-kit-build` Test(s) (#492) * Reinstate build test * Add regenerator-runtime to internal-lib-build Co-authored-by: vcua-mobify <vcua@salesforce.com> * [V2]Generate different reports for different bundles (#508) * generate different reports for different bundles * fix report bundle size script * Remove old config implementation from bad merge (#513) * [V2] Re-Enable Windows Node 14 CI Workflow (#487) * Re-enable windows node 14 workflow * Fix glob string cross environment * Testing removing restore_cache * Testing forceExit flag * Testing not running lint * Debugging using double quotes * Force crlf line ending for mrt.js file * Revert "Force crlf line ending for mrt.js file" This reverts commit b249e0f. * Test not running tests on templates * Re-enable lint * Testing adding eslint at root * Revert "Testing adding eslint at root" This reverts commit 531fe6a. * clean up * Try again crlf on mrt.js * Revert "Try again crlf on mrt.js" This reverts commit 301826c. * Lint fix template-typescript-minimal * Enable eslint debug flag * Remove silent flag * Enable eslint debug flag for internal-lib-build * Fix glob string cross env on internal-lib-build script * Remove lerna parallel flag on lint script * Remove eslint debug flags * Exclude tsx files from lint * Debug mrt eslint * Re-enable eslint debug flags * Testing Windows xlarge * Fix mrt pkgRoot * Print more logs * Testing npm ci on Windows * Clean up * Testing lerna link * Add lerna link to setup_windows circle ci step * Add docs to Circle CI config * typo Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump Verdaccio to latest (#518) * [V2] Fix Circular Dependency Warnings (#514) * Remove CLI dev dependency causing circular dependency warnings Co-authored-by: Oliver Brook <olibrook@gmail.com> * Update copyrights and template. (#516) * v2 fix old naming (#521) * v2 replace old name mobify-platform-sdk references to pwa-kit * fix typo in readme and jsdoc (#530) * [V2] Fix source maps cannot be found when debugging the server (#526) * fix source map not working for server-side debugging * [V2] Loading page: avoid seeing infinite reloads (#532) * [V2] Fix invalid refresh token (#528) * fix tests * fix merge issue * fix test * [V2] Allow pass thru cli options for test command (#537) * Allow jest option to pass thru * remove useless test env * Remove lodash and bluebird. (#534) * Don't count untestable line towards code coverage. * Remove lodash and bluebird. * Oops, a semi! * Revert to util.promisify so tests pass. * Refactor to fix tests. * Fix l10n scripts to use and output to the correct file (#539) This hardcoding of the default locale was done in V1, but it was not done in V2 yet.. until now. * Merge branch `release 2.0.x` into `v2` (#542) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com>

…ev.5` (#547) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Preview release `2.0.0-dev.4` (#544) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * bump 2.0.0-dev.4 (#502) * bump * fix version * Optimize visibility-off.svg (#512) * [V2] Rename 'pwa' directory into 'template-retail-react-app' (#485) * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa directory to template-retail-react-app * Update readme and circleci config * Update pwa references in generator to template-retail-react-app * Clean up comments * Update report-bundle-size.js * Rename pwa-kit-build package and mrt CLI to pwa-kit-cli (package + CLI) (#481) * Rename pwa-kit-build/mrt to sf-mrt. * Rename sf-mrt to pwa-kit-cli * Rename mrt file to cli * Rename sf-mrt directory to pwa-kit-cli * Use pwa-kit-cli instead of pwa-kit-build. * Move loading screen from pwa-kit-build to pwa-kit-cli * Update CLI human-readable name. * [V2] Reinstate `pwa-kit-build` Test(s) (#492) * Reinstate build test * Add regenerator-runtime to internal-lib-build Co-authored-by: vcua-mobify <vcua@salesforce.com> * [V2]Generate different reports for different bundles (#508) * generate different reports for different bundles * fix report bundle size script * Remove old config implementation from bad merge (#513) * [V2] Re-Enable Windows Node 14 CI Workflow (#487) * Re-enable windows node 14 workflow * Fix glob string cross environment * Testing removing restore_cache * Testing forceExit flag * Testing not running lint * Debugging using double quotes * Force crlf line ending for mrt.js file * Revert "Force crlf line ending for mrt.js file" This reverts commit b249e0f. * Test not running tests on templates * Re-enable lint * Testing adding eslint at root * Revert "Testing adding eslint at root" This reverts commit 531fe6a. * clean up * Try again crlf on mrt.js * Revert "Try again crlf on mrt.js" This reverts commit 301826c. * Lint fix template-typescript-minimal * Enable eslint debug flag * Remove silent flag * Enable eslint debug flag for internal-lib-build * Fix glob string cross env on internal-lib-build script * Remove lerna parallel flag on lint script * Remove eslint debug flags * Exclude tsx files from lint * Debug mrt eslint * Re-enable eslint debug flags * Testing Windows xlarge * Fix mrt pkgRoot * Print more logs * Testing npm ci on Windows * Clean up * Testing lerna link * Add lerna link to setup_windows circle ci step * Add docs to Circle CI config * typo Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump Verdaccio to latest (#518) * [V2] Fix Circular Dependency Warnings (#514) * Remove CLI dev dependency causing circular dependency warnings Co-authored-by: Oliver Brook <olibrook@gmail.com> * Update copyrights and template. (#516) * v2 fix old naming (#521) * v2 replace old name mobify-platform-sdk references to pwa-kit * fix typo in readme and jsdoc (#530) * [V2] Fix source maps cannot be found when debugging the server (#526) * fix source map not working for server-side debugging * [V2] Loading page: avoid seeing infinite reloads (#532) * [V2] Fix invalid refresh token (#528) * fix tests * fix merge issue * fix test * [V2] Allow pass thru cli options for test command (#537) * Allow jest option to pass thru * remove useless test env * Remove lodash and bluebird. (#534) * Don't count untestable line towards code coverage. * Remove lodash and bluebird. * Oops, a semi! * Revert to util.promisify so tests pass. * Refactor to fix tests. * Fix l10n scripts to use and output to the correct file (#539) This hardcoding of the default locale was done in V1, but it was not done in V2 yet.. until now. * Merge branch `release 2.0.x` into `v2` (#542) * Fix lint errors * Review release 2.0.0-dev.3 (#499) * Bump V2 (aka V2 develop) to 2.0.0-dev.3 (#486) * Bump version * Fix lint errors * [BFH] Make hello-world public in the generator, give it a presentable README (#393) * Rename hello-world -> express-minimal, make public in generator * Format * Format * [v2] Rename template-1c -> template-typescript-minimal (#494) * Rename template-1c -> template-typescript-minimal * Format * [V2] Fix rejected 3PP (#488) * Remove `lodash.debounce` & Bump `njwt` to latest * Bump `sinon` to latest * Solve merge conflicts * Update lighthouse score thresholds (#491) * [V2]add eslintrc.js to project templates (#495) * add eslintrc.js to project templates * [V2] Hide webpack perf warnings for `pwa` and use `bundlesize` instead (#471) * [V2] allow custom webpack config in projects (#462) * Allow projects to build or start dev server with a custom webpack config * Add webpack config placeholders in app templates * Cleanup optional webpack config in PWA * Update packages/pwa-kit-build/bin/mrt.js Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Solve merge conflicts Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> * Bump version `2.0.0-dev.5` * Bump root package-lock.json file version to 2.0.0-dev.5 Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: vcua-mobify <vcua@salesforce.com> Co-authored-by: Oliver Brook <olibrook@gmail.com>

generate different reports for different bundles

cac9460

alexvuong requested a review from a team as a code owner April 7, 2022 23:25

alexvuong self-assigned this Apr 7, 2022

alexvuong added the ready for review PR is ready to be reviewed label Apr 7, 2022

Change title in WebpackNotifierPlugin

cfc6e9a

alexvuong commented Apr 7, 2022

View reviewed changes

packages/pwa-kit-build/src/configs/webpack/config.js Outdated Show resolved Hide resolved

wjhsf approved these changes Apr 11, 2022

View reviewed changes

alexvuong added 2 commits April 11, 2022 14:11

do not adjust statFilename

804587c

add statFileName and adjust report bundle script

0fad8d6

alexvuong commented Apr 11, 2022

View reviewed changes

scripts/report-bundle-size.js Outdated Show resolved Hide resolved

bendvc reviewed Apr 11, 2022

View reviewed changes

packages/pwa-kit-build/src/configs/webpack/config.js Outdated Show resolved Hide resolved

alexvuong changed the title ~~Generate different reports for different bundles~~ [V2]Generate different reports for different bundles Apr 11, 2022

alexvuong added 2 commits April 11, 2022 14:53

filter falsy on plugins

c775605

Merge branch 'v2' into generate-different-report-webpack-analyzer-v2

b7fda85

vmarta reviewed Apr 12, 2022

View reviewed changes

alexvuong added 5 commits April 12, 2022 12:04

Try getting bundle names from webpack config

04eca33

Revert "Try getting bundle names from webpack config"

8b8b195

This reverts commit 04eca33.

grab the stat files by their conventioned name to report bundle size

82a8db4

Merge branch 'v2' into generate-different-report-webpack-analyzer-v2

46faa55

change main to client for bundle analyzer

271e82c

alexvuong commented Apr 13, 2022

View reviewed changes

vmarta reviewed Apr 13, 2022

View reviewed changes

wjhsf reviewed Apr 13, 2022

View reviewed changes

alexvuong added 3 commits April 13, 2022 15:14

PR feedback

bc1d050

Merge branch 'v2' into generate-different-report-webpack-analyzer-v2

e7522e3

use readdir promise

177727f

vmarta approved these changes Apr 13, 2022

View reviewed changes

alexvuong merged commit 9bb1d87 into v2 Apr 13, 2022

This was referenced Apr 26, 2022

Preview release 2.0.0-dev.4 #543

Closed

Preview release 2.0.0-dev.4 #544

Merged

wjhsf deleted the generate-different-report-webpack-analyzer-v2 branch March 17, 2023 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[V2]Generate different reports for different bundles #508

[V2]Generate different reports for different bundles #508

alexvuong commented Apr 7, 2022 •

edited

Loading

alexvuong Apr 13, 2022

vmarta Apr 13, 2022

alexvuong Apr 13, 2022

vmarta Apr 13, 2022

wjhsf Apr 13, 2022

alexvuong Apr 13, 2022

vmarta Apr 13, 2022

vmarta Apr 13, 2022

vmarta Apr 13, 2022

vmarta Apr 13, 2022

vmarta Apr 13, 2022

wjhsf Apr 13, 2022

alexvuong Apr 13, 2022

wjhsf Apr 13, 2022

wjhsf Apr 13, 2022

wjhsf Apr 13, 2022

vmarta left a comment

	const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')
	const buildDir = path.join(path.resolve(''), 'packages', 'template-retail-react-app', 'build')

	const buildDir = path.join(path.resolve(''), 'packages', 'pwa', 'build')
	const buildDir = path.resolve('packages', 'template-retail-react-app', 'build')

	fs.readdir(buildDir, (err, files) => {
	const files = await fs.promises.readdir(buildDir)

[V2]Generate different reports for different bundles #508

[V2]Generate different reports for different bundles #508

Conversation

alexvuong commented Apr 7, 2022 • edited Loading

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

Localization

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vmarta left a comment

Choose a reason for hiding this comment

alexvuong commented Apr 7, 2022 •

edited

Loading