Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ascent record to Dashboard #167

Merged
merged 19 commits into from
Jul 23, 2022
Merged

Added ascent record to Dashboard #167

merged 19 commits into from
Jul 23, 2022

Conversation

Fmstrat
Copy link
Contributor

@Fmstrat Fmstrat commented Mar 24, 2022

No description provided.

@SamR1
Copy link
Owner

SamR1 commented Mar 27, 2022

Hi,

Thanks for your PR.

I merged the translation fix from PR#161, which generates a conflict.
Is it possible to fix it, as well as some broken tests?
To run lint and tests:

$ make check-all

I also merged new features that needed a migration.
The migration should be renamed 24_cd0e6cf83207_add_ascent_record.py
and the down revision is now e30007d681cb.

I plan to release a new version today. You can wait the release to make changes if you want.

Don't hesitate to ping me, if you have any questions.

Thanks.

@Fmstrat
Copy link
Contributor Author

Fmstrat commented Jul 18, 2022

So I'm trying to figure out the tests, but since I was developing in Docker I don't have an env set up to run them. Is there a doc anywhere for setting up for dev?

@Fmstrat
Copy link
Contributor Author

Fmstrat commented Jul 18, 2022

Tried to do this letting GitHub handle the tests, looks like I'm stuck on the DB upgrade and not sure where to go from here.

@SamR1
Copy link
Owner

SamR1 commented Jul 19, 2022

Hi,

The error on db upgrade is due to a wrong down revision (sorry my bad, the right down revision is 5e3a3a31c432).

I also fixed getting user records when the user has workouts without gpx file.

@SamR1
Copy link
Owner

SamR1 commented Jul 23, 2022

So I'm trying to figure out the tests, but since I was developing in Docker I don't have an env set up to run them. Is there a doc anywhere for setting up for dev?

I added some commands to run tests and lint with docker (see #222)

@SamR1 SamR1 merged commit ab432d6 into SamR1:dev Jul 23, 2022
@SamR1 SamR1 mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants