Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user preference for filtering of GPX speed data #358

Merged
merged 10 commits into from
May 28, 2023

Conversation

jat255
Copy link
Contributor

@jat255 jat255 commented May 21, 2023

This PR partially addresses #48 (although it's not perfect).

Basically, it adds a new user preference (use_raw_gpx_speed) that instructs FitTrackee to pass raw=True to gpxpy's get_moving_data method when parsing a GPX file. It works as advertised, but it's not really a perfect solution. Perhaps a better/more flexible solution would be to add a preference that gets passed to that method's speed_extreemes_percentiles parameter, which would allow for tuning of the behavior (including setting it to 0, which would be the same as raw=True). I could do it that way if it's better.

Ultimately, this seems (to me) a limitation of how gpxpy implements filtering, which is to calculate all the speeds for the GPX file as-is and then discard some percentage of the top ones. Other GPS applications appear to eliminate actual GPS outlier points (see this part of GPXSee for example)

I added translations for the new user preference strings, but they're just from google translate, so they could probably use some review.

Here's what the preference setting looks like:

image

image

@SamR1
Copy link
Owner

SamR1 commented May 28, 2023

Hi,

thanks for the PR.

@SamR1 SamR1 merged commit a74c03d into SamR1:dev May 28, 2023
@jat255 jat255 deleted the max_speed_preference branch July 2, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants