Support JRuby by removing fast_stack as a hard dependency #11

Merged
merged 1 commit into from Apr 17, 2015

Projects

None yet

2 participants

@nilbus
Contributor
nilbus commented Apr 8, 2015

Since fast_stack uses a C extension, it is not compatible with JRuby. With this patch, fast_stack will be used when it is available, only after after using StackProf if that is available.

Tested manually on JRuby, and the specs still pass on MRI.

What do you think about this approach?

@nilbus nilbus Support JRuby by removing fast_stack as a hard dependency
fast_stack will be used when it is available, only after
after using StackProf if that is available.
3f2dcf6
@SamSaffron
Owner

In principal I am ok with this, but can you confirm you can get stack traces fast enough from JRuby to even make this project useful for JRuby ?

A screenshot perhaps?

@nilbus
Contributor
nilbus commented Apr 17, 2015

Here's a screenshot, but how do you know what the sample rate is?

image 2015-04-08 at 2 32 06 pm

@SamSaffron
Owner

That flamegraph does seem useful, you can get a rough measure of your
sample rate by figuring out how long it takes to execute the page without
flame graph and then dividing by the number of samples you got in the
graph.

On Fri, Apr 17, 2015 at 11:58 AM, Edward Anderson notifications@github.com
wrote:

Here's a screenshot, but how do you know what the sample rate is?

[image: image 2015-04-08 at 2 32 06 pm]
https://cloud.githubusercontent.com/assets/64751/7194788/ad001d6e-e483-11e4-8b72-2b825ad6b3a1.png


Reply to this email directly or view it on GitHub
#11 (comment).

@SamSaffron SamSaffron merged commit 3c15623 into SamSaffron:master Apr 17, 2015
@SamSaffron
Owner

cool I merged this

@nilbus
Contributor
nilbus commented Apr 17, 2015
@dgynn dgynn referenced this pull request in MiniProfiler/rack-mini-profiler Oct 6, 2016
Merged

Improve README for profile-memory options and flamegraph dependencies #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment