Support JRuby by removing fast_stack as a hard dependency#11
Conversation
fast_stack will be used when it is available, only after after using StackProf if that is available.
|
In principal I am ok with this, but can you confirm you can get stack traces fast enough from JRuby to even make this project useful for JRuby ? A screenshot perhaps? |
|
That flamegraph does seem useful, you can get a rough measure of your On Fri, Apr 17, 2015 at 11:58 AM, Edward Anderson notifications@github.com
|
Support JRuby by removing fast_stack as a hard dependency
|
cool I merged this |
|
I probably won't have time to go back and redo the flame graph to measure
the sample rate, but it was a high enough sample rate to be useful.
|

Since fast_stack uses a C extension, it is not compatible with JRuby. With this patch, fast_stack will be used when it is available, only after after using StackProf if that is available.
Tested manually on JRuby, and the specs still pass on MRI.
What do you think about this approach?