Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'hide_x_bottom_lines' and 'sort_alphabetically' options #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BrVer
Copy link

@BrVer BrVer commented May 19, 2017

Tool works nice, however I missed some functionality:

  1. ability to not display X bottom lines of the stacktrace, as it's usually some rails initialization stuff which only takes extra place
  2. ability to sort stacktraces alphabetically, so the same stacktraces will be grouped into one big column instead of being splitted across the chart

The second option gives next benefits:

  • it's really easy to visually determine which parts of code take the most CPU time
  • chart size is reduced dramatically, especially if you're using much loops in your code (for me it reduced from 40MB, which crashed browser tab, to ~1.5MB which can be opened without such risk)
  • original flamegraph (https://github.com/brendangregg/FlameGraph) works this way, so it will be convenient to add such option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant