Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Add support for RxJS 6 #89

Merged
merged 2 commits into from
Apr 11, 2018

Conversation

brandonroberts
Copy link

@brandonroberts brandonroberts commented Apr 5, 2018

Also cleans up linter errors with latest version of xo

BREAKING CHANGE:

Minimum dependency on RxJS is ^5.6.0-forward-compat.0 || ^6.0.0-rc.1

@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files           7        7           
  Lines         189      189           
=======================================
  Hits          182      182           
  Misses          7        7
Impacted Files Coverage Δ
index.js 100% <ø> (ø) ⬆️
lib/task-wrapper.js 90% <ø> (ø) ⬆️
lib/task.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28fb95...fbed3ef. Read the comment docs.

@SamVerschueren
Copy link
Owner

Hi @brandonroberts, thanks for your PR! And for all the lint fixes.

Just one question, is there a reason to already make the switch to RxJS instead of waiting until it's stable?

@brandonroberts
Copy link
Author

The error is going to bite users who are testing out release candidates. For people who wait until everything is official it will it may only fail if they don't install the compatibility package. I came across the failure due to the upstream lint-staged package I was using with husky when I was upgrading to the latest release candidate. Installing the rxjs-compat package along with the latest RxJS release candidate solves the issue.

@SamVerschueren
Copy link
Owner

SamVerschueren commented Apr 10, 2018

Ah okay! Thanks for your explanation! Makes sense. Can you upgrade the rc version? It's already rc.1 if I'm not mistaken.

Brandon Roberts added 2 commits April 10, 2018 13:06
BREAKING CHANGE:

Minimum dependency on RxJS is ^5.6.0-forward-compat.0 || ^6.0.0-rc.1
@brandonroberts
Copy link
Author

Done

@SamVerschueren SamVerschueren merged commit 42f38c2 into SamVerschueren:master Apr 11, 2018
@SamVerschueren
Copy link
Owner

Sweet! Thank you very much for your effort @brandonroberts! Released as 0.14.0.

@SamVerschueren
Copy link
Owner

@brandonroberts Care to help me out with an issue downstream in any-observable? I guess you know a little more about RxJS 6 and it's changes :).

Issue is described here sindresorhus/any-observable#18. It causes a failure in lint-staged.

@brandonroberts brandonroberts deleted the fix-rxjs-6 branch April 11, 2018 12:54
@brandonroberts
Copy link
Author

Sure. I left a comment on the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants