-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): Add support for RxJS 6 #89
fix(deps): Add support for RxJS 6 #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 7 7
Lines 189 189
=======================================
Hits 182 182
Misses 7 7
Continue to review full report at Codecov.
|
Hi @brandonroberts, thanks for your PR! And for all the lint fixes. Just one question, is there a reason to already make the switch to RxJS instead of waiting until it's stable? |
The error is going to bite users who are testing out release candidates. For people who wait until everything is official it will it may only fail if they don't install the compatibility package. I came across the failure due to the upstream |
Ah okay! Thanks for your explanation! Makes sense. Can you upgrade the rc version? It's already rc.1 if I'm not mistaken. |
420a3ce
to
03d5b9a
Compare
BREAKING CHANGE: Minimum dependency on RxJS is ^5.6.0-forward-compat.0 || ^6.0.0-rc.1
03d5b9a
to
fbed3ef
Compare
Done |
Sweet! Thank you very much for your effort @brandonroberts! Released as |
@brandonroberts Care to help me out with an issue downstream in Issue is described here sindresorhus/any-observable#18. It causes a failure in lint-staged. |
Sure. I left a comment on the issue |
Also cleans up linter errors with latest version of
xo
BREAKING CHANGE:
Minimum dependency on RxJS is ^5.6.0-forward-compat.0 || ^6.0.0-rc.1