Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work with RxJS 6 #18

Closed
SamVerschueren opened this issue Apr 11, 2018 · 2 comments
Closed

Doesn't seem to work with RxJS 6 #18

SamVerschueren opened this issue Apr 11, 2018 · 2 comments

Comments

@SamVerschueren
Copy link
Contributor

Is it possible that the auto detect feature doesn't work for RxJS 6? Might have to pull in @benlesh here because I'm not sure what all the changes are in this new version.

So we try to load in rxjs/Observable right here. But it looks like that doesn't exist anymore and you need to import directly from rxjs instead.

So we can easily fix this by adding rxjs to the libs list as the last element in order to support RxJS 6. But before I do a PR, I need to be sure that my findings are correct.

@brandonroberts
Copy link

brandonroberts commented Apr 11, 2018

@SamVerschueren Your finding is correct that for RxJS 6, the Observable import should come from rxjs. If the consumer has the rxjs-compat package installed also, either import path will work with version 6.

@benlesh
Copy link

benlesh commented Apr 20, 2018

This is likely because import locations changed with RxJS 6. It's hard to say, because I don't have time to dig into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants