Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run_doc_benchmark #534

Merged
merged 11 commits into from
Apr 16, 2024
Merged

Add run_doc_benchmark #534

merged 11 commits into from
Apr 16, 2024

Conversation

csh519
Copy link
Collaborator

@csh519 csh519 commented Apr 15, 2024

Description

This PR is for process CredData DOC BMT.
CredData DOC BMT is done internally, and just update the commit status when PR timing.
You can check the result through the commit status of b8bdb1a at csh519#8.

  • Add DOC BMT feature

How has this been tested?

  • Benchmark

@csh519 csh519 requested a review from a team as a code owner April 15, 2024 11:06
@csh519 csh519 changed the title [TEST] Add run_doc_benchmark Add run_doc_benchmark Apr 15, 2024
COMMIT_SHA=$(git rev-parse HEAD)
curl -X POST ${{ secrets.SLACK_URL}} \
--data-urlencode \
"payload={'text':'[BMT Request] ${{ github.event.repository.html_url }}/commit/${COMMIT_SHA}'}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps, there is URL missing

curl: no URL specified!
curl: try 'curl --help' or 'curl --manual' for more information

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url is slack webhook url, so it should be encapsulated..
So I used repository -> secrets for hiding webhook url, and this can't be triggered from PR as I know.
Please check below.

https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build

@babenek babenek self-requested a review April 16, 2024 03:53
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. The workflow works.

Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@csh519 csh519 merged commit 39bade0 into Samsung:main Apr 16, 2024
29 of 31 checks passed
@csh519 csh519 deleted the add_doc_bmt branch April 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants