-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs with adding / removing lights #1899
Conversation
Fixed faulty C++ logic for notifying components when they are removed / added from scene Delete light block when light list is cleared (from rendering thread) This fixes intermittent failures with SIDIA lighting tests
Fixes crash in normal mapping test
Will this have any impact on the outstanding issue in PR #1825 where lights are not turned on when loading a new X3D scene? A sample test is included with the PR. |
Planning to merge on Tuesday. @NolaDonato Which tests in particular you expect to pass reliably. For me meshWithLightingTest fails; LightTests crash. Maybe none of these are affected by this PR; have not verified without. LightTests crash:
|
The crash seems to be happening during the tear down of a test case. Maybe LightList::useLights needs mLightBlock nullptr check (& lock?). |
@mwitchwilliams #1825 doesn't seem to get affected by this pr. |
I figured out what caused the crash and fixed it. |
Fixed faulty C++ logic for notifying components when they are removed /
added from scene
Delete light block when light list is cleared (from rendering thread)
This fixes intermittent failures with SIDIA lighting tests
GearVRF DCO signed off by: Nola Donato nola.donato@samsung.com