refactor: Change table names, replace native queries with a non-native #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
o-kopysov
requested review from
tiokim,
MoonkiHong and
tdrozdovsky
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
============================================
- Coverage 92.61% 92.54% -0.07%
- Complexity 528 529 +1
============================================
Files 48 48
Lines 1733 1731 -2
Branches 208 208
============================================
- Hits 1605 1602 -3
Misses 64 64
- Partials 64 65 +1 ☔ View full report in Codecov by Sentry. |
tiokim
previously approved these changes
Jun 18, 2024
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
m-rudyk
reviewed
Jun 18, 2024
| value = | ||
| "SELECT * FROM license_list WHERE license_list.license_spdx = :spdxId ORDER BY id DESC LIMIT 1", | ||
| nativeQuery = true) | ||
| @Query("SELECT l FROM LPVSLicense l WHERE l.spdxId = :spdxId ORDER BY l.id DESC LIMIT 1") |
There was a problem hiding this comment.
as an option to simplify more, Repository Method Definition can be used:
eg: findTopBySpdxIdOrderByIdDesc
There was a problem hiding this comment.
We will plan such refactoring in the future. Thanks for the suggestion.
m-rudyk
reviewed
Jun 18, 2024
| @@ -39,8 +39,8 @@ void setUp() { | |||
| pullRequestUrl, | |||
| pullRequestFilesUrl, | |||
| status, | |||
| pullRequestBase, | |||
There was a problem hiding this comment.
I didn't get this change...
There was a problem hiding this comment.
Incorrect order of parameters.
m-rudyk
approved these changes
Jun 18, 2024
tdrozdovsky
approved these changes
Jun 19, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
PR contains the next changes:
Type of change
Please delete options that are not relevant.
Testing
Verified on PR: https://github.sec.samsung.net/SOSHUB/LPVS-test/pull/1543#issuecomment-2729707
Checklist: