-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename repository methods for name-based query derivation #541
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage ? 92.56%
Complexity ? 529
=======================================
Files ? 48
Lines ? 1736
Branches ? 208
=======================================
Hits ? 1607
Misses ? 64
Partials ? 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issue with naming. Happy flow works, UT pass. But we have to test more this change.
9abca3d
to
8e3ae57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
8e3ae57
to
5f3b80c
Compare
@tiokim Functional test successfully passed on current PR. |
Pull Request
Description
Current PR contains refactoring of the repository method names to enable name-based query derivation.
This change was proposed here.
Because I'm not an expert in name-based queries, I would be grateful for the careful code review.
Also, functional test run is required for this PR.
Type of change
Please delete options that are not relevant.
Testing
Unit tests - passed.
Checklist: