Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename repository methods for name-based query derivation #541

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains refactoring of the repository method names to enable name-based query derivation.
This change was proposed here.

Because I'm not an expert in name-based queries, I would be grateful for the careful code review.

Also, functional test run is required for this PR.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Unit tests - passed.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Jun 21, 2024
@o-kopysov o-kopysov added this to the v1.5.2 milestone Jun 21, 2024
@o-kopysov o-kopysov self-assigned this Jun 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0db1b06). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage        ?   92.56%           
  Complexity      ?      529           
=======================================
  Files           ?       48           
  Lines           ?     1736           
  Branches        ?      208           
=======================================
  Hits            ?     1607           
  Misses          ?       64           
  Partials        ?       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov marked this pull request as ready for review June 25, 2024 08:09
m-rudyk
m-rudyk previously approved these changes Jun 25, 2024
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue with naming. Happy flow works, UT pass. But we have to test more this change.

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov
Copy link
Collaborator Author

@tiokim Functional test successfully passed on current PR.
Do you have any concerns or comments regarding this PR? Can we merge it?

@o-kopysov o-kopysov merged commit 313158b into main Jul 1, 2024
10 checks passed
@o-kopysov o-kopysov deleted the refactor-queries branch July 1, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants