[onert/api] Add TrainingInfo into nnfw_session #12342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetwhite
force-pushed
the
1220/ir_tinfo_usage
branch
3 times, most recently
from
1708de6
to
754b1e7
Compare
zetwhite
changed the title
zetwhite
force-pushed
the
1220/ir_tinfo_usage
branch
from
754b1e7
to
ce9547f
Compare
This PR adds TrainingInfo into nnfw_session. It also initalize nnfw_session._train_info in 'load_model_from_modelfile' and 'load_model_from_nnpackage'. ONE-DCO-1.0-Signed-off-by: SeungHui Youn <sseung.youn@samsung.com>
zetwhite
force-pushed
the
1220/ir_tinfo_usage
branch
from
ce9547f
to
cae870a
Compare
zetwhite
commented
Dec 21, 2023
| @@ -206,6 +210,7 @@ struct nnfw_session | |||
| std::shared_ptr<onert::api::CustomKernelRegistry> _kernel_registry; | |||
| std::vector<std::thread> _threads; | |||
| uint32_t _training_step{0}; | |||
| std::unique_ptr<onert::ir::train::TrainingInfo> _train_info; | |||
There was a problem hiding this comment.
@Samsung/one_onert
Q: Is there a plan to support multiple models in training features?
If so, Since the session hold multiple models through _nnpkg, It might be better to add a vector of Training info
Suggested change
| std::unique_ptr<onert::ir::train::TrainingInfo> _train_info; | |
| std::vector<std::unique_ptr<onert::ir::train::TrainingInfo>> _train_info; |
I thought there no plan for support multiple model training at near future.
So, I'd like to save first model(primary model)'s TrainingInfo in the session, for now.
zetwhite
commented
Dec 21, 2023
| @@ -402,6 +405,9 @@ NNFW_STATUS nnfw_session::load_model_from_nnpackage(const char *package_dir) | |||
| _coptions.push_back(onert::compiler::CompilerOptions::fromGlobalConfig()); | |||
| } | |||
|
|
|||
| // TODO load TrainingInfo from model, using TraininfoLoader | |||
There was a problem hiding this comment.
(note)
more exaclty load TrainingInfo from "primary model" using TrainInfoLoader
hseok-oh
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TrainingInfo into nnfw_session.
It also initalize nnfw_session._train_info in 'load_model_from_modelfile' and 'load_model_from_nnpackage'.
ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com
issue : #11692
draft : #12152.