[onert/api] Add nnfw_train_get_traininfo #12391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds nnfw_train_get_traininfo API. This api is to get training info from the session. ONE-DCO-1.0-Signed-off-by: SeungHui Youn <sseung.youn@samsung.com>
zetwhite
added
approval: 2
zetwhite
commented
Dec 29, 2023
| @@ -192,6 +195,7 @@ typedef enum | |||
|
|
|||
| typedef enum | |||
| { | |||
| NNFW_TRAIN_OPTIMIZER_UNDEF = -1, | |||
There was a problem hiding this comment.
Q : Why *_UNDEF are added to enums?
A :
nnfw_train_get_traininfo api is to get training info for the user application.
Since we can NOT guarantee that the session always holds every training information,
some fields can be invalid value. (missing value is represented as invalid in core by default)
So, To represent invalid value in the user application, *_UNDEF fields become necessary.
zetwhite
removed
the
PR/ready for review
jyoungyun
reviewed
Dec 29, 2023
glistening
reviewed
Jan 2, 2024
| @@ -176,12 +176,15 @@ NNFW_STATUS nnfw_pop_pipeline_output(nnfw_session *session, void *outputs); | |||
| ////////////////////////////////////////////// | |||
| typedef enum | |||
| { | |||
| NNFW_TRAIN_LOSS_UNDEF = -1, | |||
There was a problem hiding this comment.
I prefer full name (UNDEFINED) instead of UNDEF.
Suggested change
| NNFW_TRAIN_LOSS_UNDEF = -1, | |
| NNFW_TRAIN_LOSS_UNDEFINED = -1, |
Also, I like to use 0 for undefined. But I don't want to block this PR. Let's change if others agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds nnfw_train_get_traininfo API.
This api is to get training info from the session.
ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com
related : #11692