-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert/api] Add nnfw_train_get_traininfo #12391
Conversation
This PR adds nnfw_train_get_traininfo API. This api is to get training info from the session. ONE-DCO-1.0-Signed-off-by: SeungHui Youn <sseung.youn@samsung.com>
@@ -192,6 +195,7 @@ typedef enum | |||
|
|||
typedef enum | |||
{ | |||
NNFW_TRAIN_OPTIMIZER_UNDEF = -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q : Why *_UNDEF
are added to enums?
A :
nnfw_train_get_traininfo
api is to get training info for the user application.
Since we can NOT guarantee that the session always holds every training information,
some fields can be invalid
value. (missing value is represented as invalid
in core by default)
So, To represent invalid
value in the user application, *_UNDEF
fields become necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -176,12 +176,15 @@ NNFW_STATUS nnfw_pop_pipeline_output(nnfw_session *session, void *outputs); | |||
////////////////////////////////////////////// | |||
typedef enum | |||
{ | |||
NNFW_TRAIN_LOSS_UNDEF = -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer full name (UNDEFINED
) instead of UNDEF
.
NNFW_TRAIN_LOSS_UNDEF = -1, | |
NNFW_TRAIN_LOSS_UNDEFINED = -1, |
Also, I like to use 0
for undefined. But I don't want to block this PR. Let's change if others agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upated. PTAL :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds nnfw_train_get_traininfo API.
This api is to get training info from the session.
ONE-DCO-1.0-Signed-off-by: SeungHui Youn sseung.youn@samsung.com
related : #11692